From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kangjie Lu <kjlu@umn.edu>
Cc: devel@driverdev.osuosl.org, Kees Cook <keescook@chromium.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, pakki001@umn.edu,
Aymen Qader <qader.aymen@gmail.com>
Subject: Re: [PATCH] rts5208: add a missing check for the status of command sending
Date: Thu, 20 Dec 2018 12:27:45 +0300 [thread overview]
Message-ID: <20181220092745.GH15451@kadam> (raw)
In-Reply-To: <20181220075704.40732-1-kjlu@umn.edu>
I think maybe this is the first kernel patch I have recieved from you.
When you're adding error handling there are a couple ways to go wrong
and this is what I look at when I review error handling patches:
1) The error handling is not required.
2) The error handling is not complete.
I have messed up on both of these in my own patches because sometimes
the code is complicated to understand. Sometimes there isn't any way
to recover from errors. For example, we sometimes deliberately assume
that the PCI bus is working because if it's not the real fix is to buy
new hardware.
Another thing that helps is to try write about the real world impact
about the patch in the changelog. Try ask, why has that bug not been
found before? Always take a look at how the function is called and the
wider context.
regards,
dan carpenter
next prev parent reply other threads:[~2018-12-20 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 7:57 [PATCH] rts5208: add a missing check for the status of command sending Kangjie Lu
2018-12-20 9:09 ` Dan Carpenter
2018-12-20 9:27 ` Dan Carpenter [this message]
2018-12-20 17:31 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220092745.GH15451@kadam \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=qader.aymen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox