Re: [RFC][PATCH] printk: increase devkmsg write() ratelimit

Borislav Petkov
2018-12-18T17:47:32Z

On Wed, Dec 19, 2018 at 01:52:17AM +0900, Sergey Senozhatsky wrote:
> But devkmsg ratelimits systemd errors, so one does not even know that
> "some debugging is required". For instance from my x86 box:
>
> Unmounting /home...
> [..]
> home.mount: Mount process exited, code=exited status=32
> Failed unmounting /home.
>
> I don't want to debug systemd, I want to know that something didn't
> work out. 10 messages max and 5 seconds interval looks a bit too strict.

So how much is not strict?

And what happens if you raise that ratelimiting level and the *one* line
which is most important for debugging an issue, still doesn't get logged
because all of a sudden, doofus is more talkative, overflows the new
limit and we drop the important line?

All I'm saying is, gradually raising the limit is the wrong approach
- there will always be a case where something important doesn't get
logged.

What we need is a different solution, maybe what Rostedt proposes or
so...

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.