From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH -next] regulator: act8945a-regulator: make symbol act8945a_pm static
Date: Thu, 20 Dec 2018 11:45:50 +0100 [thread overview]
Message-ID: <20181220114550.782cdddc@bbrezillon> (raw)
In-Reply-To: <1545117021-178814-1-git-send-email-weiyongjun1@huawei.com>
On Tue, 18 Dec 2018 07:10:21 +0000
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> Fixes the following sparse warning:
>
> drivers/regulator/act8945a-regulator.c:340:1: warning:
> symbol 'act8945a_pm' was not declared. Should it be static?
>
> Fixes: 7482d6ecc68e ("regulator: act8945a-regulator: Implement PM functionalities")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> drivers/regulator/act8945a-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/act8945a-regulator.c b/drivers/regulator/act8945a-regulator.c
> index 90572b6..dc3942b 100644
> --- a/drivers/regulator/act8945a-regulator.c
> +++ b/drivers/regulator/act8945a-regulator.c
> @@ -337,7 +337,7 @@ static int act8945a_suspend(struct device *pdev)
> return regmap_write(act8945a->regmap, ACT8945A_SYS_CTRL, 0x42);
> }
>
> -SIMPLE_DEV_PM_OPS(act8945a_pm, act8945a_suspend, NULL);
> +static SIMPLE_DEV_PM_OPS(act8945a_pm, act8945a_suspend, NULL);
>
> static void act8945a_pmic_shutdown(struct platform_device *pdev)
> {
>
>
>
prev parent reply other threads:[~2018-12-20 10:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 7:10 [PATCH -next] regulator: act8945a-regulator: make symbol act8945a_pm static Wei Yongjun
2018-12-20 10:45 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220114550.782cdddc@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox