Re: [PATCH 06/15] drm/rockchip: analogix_dp: add support for the rk3368 variant

Rob Herring
2018-12-20T21:40:54Z

On Mon, 17 Dec 2018 13:36:41 +0100, Heiko Stuebner wrote:
> Add the compatible and allow the driver to also not set any crtc input
> on socs that only have one vop. While that was already possible
> because the driver checked against the grf-reg being 0, make that
> var an int as "0x0" is a valid grf address itself. So standardize
> on -1 for "no setting needed".
>
> The dp controller behaves similar to the one found on rk3288, so we
> don't add a new chip_type to not overly pollute the bridge driver.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> .../display/rockchip/analogix_dp-rockchip.txt | 1 +
> drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 17 +++++++++++++----
> 2 files changed, 14 insertions(+), 4 deletions(-)
>

Reviewed-by: Rob Herring <robh@kernel.org>