From: Lee Jones <lee.jones@linaro.org>
To: Kangjie Lu <kjlu@umn.edu>
Cc: pakki001@umn.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: mc13xxx: fix a missing check of a register-read failure
Date: Fri, 21 Dec 2018 14:52:10 +0000 [thread overview]
Message-ID: <20181221145210.GT13248@dell> (raw)
In-Reply-To: <20181220211211.32608-1-kjlu@umn.edu>
On Thu, 20 Dec 2018, Kangjie Lu wrote:
> When mc13xxx_reg_read() fails, "old_adc0" is uninitialized and will
> contain random value. Further execution uses "old_adc0" even when
> mc13xxx_reg_read() fails.
> The fix checks the return value of mc13xxx_reg_read(), and exits
> the execution when it fails.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> drivers/mfd/mc13xxx-core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2018-12-21 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 21:12 [PATCH] mfd: mc13xxx: fix a missing check of a register-read failure Kangjie Lu
2018-12-21 14:52 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221145210.GT13248@dell \
--to=lee.jones@linaro.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox