From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72C4DC43387 for ; Sat, 22 Dec 2018 17:33:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3375521A4E for ; Sat, 22 Dec 2018 17:33:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545499991; bh=8/LY6lDJ7IIERYkajvRpa/B8M1vxZgnuxDTNBRHpuOc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=kTYOmPqHqa7N+fpPFy+PeQy+3Ik5J+t3DGCvJ6tObTPd9NUY/7O3rs0SHItevkkef dlvSjtEXS0h1oc8GOtssi6Nyg07v1GgKjLjzvqaRFVpb7G92Z26V5kxWanwNRHLkfM /wPFOr6OgubAu+Z9f2DTAHlda5m+rpuTMCNJkjgo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392583AbeLVRdK (ORCPT ); Sat, 22 Dec 2018 12:33:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:57178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391420AbeLVRdI (ORCPT ); Sat, 22 Dec 2018 12:33:08 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D927421A47; Sat, 22 Dec 2018 17:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545499987; bh=8/LY6lDJ7IIERYkajvRpa/B8M1vxZgnuxDTNBRHpuOc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=o7FsBtDJdsdj/Lgow1UXR9D4mo+eZfFOcGptifMhDvSwMrAww/vlw1idxsUFpNftn pl2PdlaBoDplvo7ywVo6AAoULSJeEzHXtUhVGpo4nhJtzdmRBlAzy+eI4Y7MxrdIkH QY73hckwJuwGOCBhA7QyoqY5ufcbfnksXvUJM898= Date: Sat, 22 Dec 2018 17:33:02 +0000 From: Jonathan Cameron To: Amir Mahdi Ghorbanian Cc: lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] Staging: iio: adis16203: fixed a SPDX identifier tag mistake Message-ID: <20181222173302.1204162e@archlinux> In-Reply-To: <1545349613-4607-1-git-send-email-indigoomega021@gmail.com> References: <1545349613-4607-1-git-send-email-indigoomega021@gmail.com> X-Mailer: Claws Mail 3.17.2 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Dec 2018 15:46:53 -0800 Amir Mahdi Ghorbanian wrote: > Fixed a coding style mistake by adding the SPDX identifier tag to the > first line of the code > > Signed-off-by: Amir Mahdi Ghorbanian Two things. It's not a 'mistake' as this driver massively predates the use of SPDX tags! Also, there is a problem here as it's current licensing is inconsistent. The MODULE_LICENSE is GPL-2.0 which would be GPL-2.0 (no +) but the original comment was +. Michael, do you want to take a view on this one? Copyright is Analog's so should be fine if you say what is preferred. Thanks, Jonathan > --- > drivers/staging/iio/accel/adis16203.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c > index 5cc96c80..4ae5b74 100644 > --- a/drivers/staging/iio/accel/adis16203.c > +++ b/drivers/staging/iio/accel/adis16203.c > @@ -1,9 +1,9 @@ > +// SPDX-License-Identifier: GPL-2.0+ > /* > * ADIS16203 Programmable 360 Degrees Inclinometer > * > * Copyright 2010 Analog Devices Inc. > * > - * Licensed under the GPL-2 or later. > */ > > #include