From: Jonathan Cameron <jic23@kernel.org>
To: Stefan Popa <stefan.popa@analog.com>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>,
<Michael.Hennerich@analog.com>, <knaack.h@gmx.de>,
<lars@metafoo.de>, <pmeerw@pmeerw.net>,
<gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
<linux-iio@vger.kernel.org>, <devel@driverdev.osuosl.org>
Subject: Re: [PATCH v2 2/6] staging: iio: adc: ad7606: Use SPDX identifier
Date: Sat, 22 Dec 2018 17:47:19 +0000 [thread overview]
Message-ID: <20181222174719.424b8fc2@archlinux> (raw)
In-Reply-To: <1545049420-16484-3-git-send-email-stefan.popa@analog.com>
On Mon, 17 Dec 2018 14:23:36 +0200
Stefan Popa <stefan.popa@analog.com> wrote:
> This patch replaces the license text at the top of ad7606 driver files
> and instead adds SPDX GPL-2.0 license identifier.
>
> Signed-off-by: Stefan Popa <stefan.popa@analog.com>
> ---
> drivers/staging/iio/adc/ad7606.c | 5 ++---
> drivers/staging/iio/adc/ad7606.h | 3 +--
> drivers/staging/iio/adc/ad7606_par.c | 5 ++---
> drivers/staging/iio/adc/ad7606_spi.c | 5 ++---
> 4 files changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7606.c b/drivers/staging/iio/adc/ad7606.c
> index e1d85b7..97b4a83 100644
> --- a/drivers/staging/iio/adc/ad7606.c
> +++ b/drivers/staging/iio/adc/ad7606.c
> @@ -1,9 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * AD7606 SPI ADC driver
> *
> * Copyright 2011 Analog Devices Inc.
> - *
> - * Licensed under the GPL-2.
> */
>
> #include <linux/interrupt.h>
> @@ -531,4 +530,4 @@ EXPORT_SYMBOL_GPL(ad7606_pm_ops);
>
> MODULE_AUTHOR("Michael Hennerich <michael.hennerich@analog.com>");
> MODULE_DESCRIPTION("Analog Devices AD7606 ADC");
> -MODULE_LICENSE("GPL v2");
> +MODULE_LICENSE("GPL");
> diff --git a/drivers/staging/iio/adc/ad7606.h b/drivers/staging/iio/adc/ad7606.h
> index 510a93d..3e12fff 100644
> --- a/drivers/staging/iio/adc/ad7606.h
> +++ b/drivers/staging/iio/adc/ad7606.h
> @@ -1,9 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * AD7606 ADC driver
> *
> * Copyright 2011 Analog Devices Inc.
> - *
> - * Licensed under the GPL-2.
> */
>
> #ifndef IIO_ADC_AD7606_H_
> diff --git a/drivers/staging/iio/adc/ad7606_par.c b/drivers/staging/iio/adc/ad7606_par.c
> index da26742..2d137b1 100644
> --- a/drivers/staging/iio/adc/ad7606_par.c
> +++ b/drivers/staging/iio/adc/ad7606_par.c
> @@ -1,9 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * AD7606 Parallel Interface ADC driver
> *
> * Copyright 2011 Analog Devices Inc.
> - *
> - * Licensed under the GPL-2.
> */
>
> #include <linux/module.h>
> @@ -114,4 +113,4 @@ module_platform_driver(ad7606_driver);
>
> MODULE_AUTHOR("Michael Hennerich <michael.hennerich@analog.com>");
> MODULE_DESCRIPTION("Analog Devices AD7606 ADC");
> -MODULE_LICENSE("GPL v2");
> +MODULE_LICENSE("GPL");
> diff --git a/drivers/staging/iio/adc/ad7606_spi.c b/drivers/staging/iio/adc/ad7606_spi.c
> index e533917..f38f0d6 100644
> --- a/drivers/staging/iio/adc/ad7606_spi.c
> +++ b/drivers/staging/iio/adc/ad7606_spi.c
> @@ -1,9 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * AD7606 SPI ADC driver
> *
> * Copyright 2011 Analog Devices Inc.
> - *
> - * Licensed under the GPL-2.
> */
>
> #include <linux/module.h>
> @@ -80,4 +79,4 @@ module_spi_driver(ad7606_driver);
>
> MODULE_AUTHOR("Michael Hennerich <michael.hennerich@analog.com>");
> MODULE_DESCRIPTION("Analog Devices AD7606 ADC");
> -MODULE_LICENSE("GPL v2");
> +MODULE_LICENSE("GPL");
Err. Nope. That is "GPL v2 or later" Guessing accidentally left behind.
I've cleaned up all 3 cases of this whilst applying. Shout if that
doesn't actually make sense. Now we have consistent SPDX and MODULE_LICENSE
with all being GPL v2 only.
Thanks,
Jonathan
next prev parent reply other threads:[~2018-12-22 17:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 12:23 [PATCH v2 0/6] staging: iio: ad7606: Move out of staging Stefan Popa
2018-12-17 12:23 ` [PATCH v2 1/6] staging: iio: adc: ad7606: Simplify the Kconfing menu Stefan Popa
2018-12-22 17:40 ` Jonathan Cameron
2018-12-17 12:23 ` [PATCH v2 2/6] staging: iio: adc: ad7606: Use SPDX identifier Stefan Popa
2018-12-22 17:47 ` Jonathan Cameron [this message]
2018-12-17 12:23 ` [PATCH v2 3/6] staging: iio: adc: ad7606: Add support for threaded irq Stefan Popa
2018-12-22 17:49 ` Jonathan Cameron
2018-12-17 12:23 ` [PATCH v2 4/6] staging: iio: adc: ad7606: Misc style fixes (no functional change) Stefan Popa
2018-12-22 17:50 ` Jonathan Cameron
2018-12-17 12:23 ` [PATCH v2 5/6] staging: iio: adc: ad7606: Move out of staging Stefan Popa
2018-12-22 17:56 ` Jonathan Cameron
2018-12-17 12:23 ` [PATCH v2 6/6] dt-bindings: iio: adc: Add docs for AD7606 ADC Stefan Popa
2018-12-22 17:58 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181222174719.424b8fc2@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox