* [PATCH] drm/bridge/panel: Remove duplicate header
@ 2018-12-24 14:32 Brajeswar Ghosh
2018-12-26 9:40 ` Laurent Pinchart
0 siblings, 1 reply; 5+ messages in thread
From: Brajeswar Ghosh @ 2018-12-24 14:32 UTC (permalink / raw)
To: architt, a.hajda, Laurent.pinchart, airlied
Cc: jrdr.linux, dri-devel, linux-kernel, sabyasachi.linux
Remove drm/drm_panel.h which is included more than once
Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
---
drivers/gpu/drm/bridge/panel.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 7cbaba213ef6..402b318eeeb2 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -15,7 +15,6 @@
#include <drm/drm_crtc_helper.h>
#include <drm/drm_encoder.h>
#include <drm/drm_modeset_helper_vtables.h>
-#include <drm/drm_panel.h>
struct panel_bridge {
struct drm_bridge bridge;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bridge/panel: Remove duplicate header
2018-12-24 14:32 [PATCH] drm/bridge/panel: Remove duplicate header Brajeswar Ghosh
@ 2018-12-26 9:40 ` Laurent Pinchart
2018-12-26 10:54 ` Sam Ravnborg
2019-01-30 14:37 ` Brajeswar Ghosh
0 siblings, 2 replies; 5+ messages in thread
From: Laurent Pinchart @ 2018-12-26 9:40 UTC (permalink / raw)
To: Brajeswar Ghosh
Cc: architt, a.hajda, airlied, jrdr.linux, dri-devel, linux-kernel,
sabyasachi.linux
Hi Brajeswar,
Thank you for the patch.
On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote:
> Remove drm/drm_panel.h which is included more than once
>
> Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
> ---
> drivers/gpu/drm/bridge/panel.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 7cbaba213ef6..402b318eeeb2 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -15,7 +15,6 @@
> #include <drm/drm_crtc_helper.h>
> #include <drm/drm_encoder.h>
> #include <drm/drm_modeset_helper_vtables.h>
> -#include <drm/drm_panel.h>
While at it, how about sorting headers alphabetically to make sure this won't
happen again ?
With that change,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> struct panel_bridge {
> struct drm_bridge bridge;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bridge/panel: Remove duplicate header
2018-12-26 9:40 ` Laurent Pinchart
@ 2018-12-26 10:54 ` Sam Ravnborg
2019-01-30 14:37 ` Brajeswar Ghosh
1 sibling, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2018-12-26 10:54 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Brajeswar Ghosh, sabyasachi.linux, airlied, linux-kernel,
dri-devel, jrdr.linux
Hi Brajeswar
> On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote:
> > Remove drm/drm_panel.h which is included more than once
> >
> > Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
> > ---
> > drivers/gpu/drm/bridge/panel.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> > index 7cbaba213ef6..402b318eeeb2 100644
> > --- a/drivers/gpu/drm/bridge/panel.c
> > +++ b/drivers/gpu/drm/bridge/panel.c
> > @@ -15,7 +15,6 @@
> > #include <drm/drm_crtc_helper.h>
> > #include <drm/drm_encoder.h>
> > #include <drm/drm_modeset_helper_vtables.h>
> > -#include <drm/drm_panel.h>
>
> While at it, how about sorting headers alphabetically to make sure this won't
> happen again ?
Even better would be to address the todo item:
"Clean up the DRM header mess" (see Documentation/gpu/todo.rst)
In other words - replace the include of "drmP.h" with the relevant header files.
Sorted, as suggested by Laurent.
Sam
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bridge/panel: Remove duplicate header
2018-12-26 9:40 ` Laurent Pinchart
2018-12-26 10:54 ` Sam Ravnborg
@ 2019-01-30 14:37 ` Brajeswar Ghosh
2019-01-30 15:15 ` Souptick Joarder
1 sibling, 1 reply; 5+ messages in thread
From: Brajeswar Ghosh @ 2019-01-30 14:37 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Archit Taneja, a.hajda, airlied, Souptick Joarder, dri-devel,
linux-kernel, Sabyasachi Gupta
On Wed, Dec 26, 2018 at 3:09 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Brajeswar,
>
> Thank you for the patch.
>
> On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote:
> > Remove drm/drm_panel.h which is included more than once
> >
> > Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
> > ---
> > drivers/gpu/drm/bridge/panel.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> > index 7cbaba213ef6..402b318eeeb2 100644
> > --- a/drivers/gpu/drm/bridge/panel.c
> > +++ b/drivers/gpu/drm/bridge/panel.c
> > @@ -15,7 +15,6 @@
> > #include <drm/drm_crtc_helper.h>
> > #include <drm/drm_encoder.h>
> > #include <drm/drm_modeset_helper_vtables.h>
> > -#include <drm/drm_panel.h>
>
> While at it, how about sorting headers alphabetically to make sure this won't
> happen again ?
>
> With that change,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
If no further comment, can we get this patch in queue for 5.1 ?
>
> > struct panel_bridge {
> > struct drm_bridge bridge;
>
> --
> Regards,
>
> Laurent Pinchart
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bridge/panel: Remove duplicate header
2019-01-30 14:37 ` Brajeswar Ghosh
@ 2019-01-30 15:15 ` Souptick Joarder
0 siblings, 0 replies; 5+ messages in thread
From: Souptick Joarder @ 2019-01-30 15:15 UTC (permalink / raw)
To: Brajeswar Ghosh
Cc: Laurent Pinchart, Archit Taneja, a.hajda, airlied, dri-devel,
linux-kernel, Sabyasachi Gupta
On Wed, Jan 30, 2019 at 8:07 PM Brajeswar Ghosh
<brajeswar.linux@gmail.com> wrote:
>
> On Wed, Dec 26, 2018 at 3:09 PM Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> >
> > Hi Brajeswar,
> >
> > Thank you for the patch.
> >
> > On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote:
> > > Remove drm/drm_panel.h which is included more than once
> > >
> > > Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
> > > ---
> > > drivers/gpu/drm/bridge/panel.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> > > index 7cbaba213ef6..402b318eeeb2 100644
> > > --- a/drivers/gpu/drm/bridge/panel.c
> > > +++ b/drivers/gpu/drm/bridge/panel.c
> > > @@ -15,7 +15,6 @@
> > > #include <drm/drm_crtc_helper.h>
> > > #include <drm/drm_encoder.h>
> > > #include <drm/drm_modeset_helper_vtables.h>
> > > -#include <drm/drm_panel.h>
> >
> > While at it, how about sorting headers alphabetically to make sure this won't
> > happen again ?
> >
> > With that change,
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> If no further comment, can we get this patch in queue for 5.1 ?
You already got a feedback from Laurent.
>
> >
> > > struct panel_bridge {
> > > struct drm_bridge bridge;
> >
> > --
> > Regards,
> >
> > Laurent Pinchart
> >
> >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-30 15:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-24 14:32 [PATCH] drm/bridge/panel: Remove duplicate header Brajeswar Ghosh
2018-12-26 9:40 ` Laurent Pinchart
2018-12-26 10:54 ` Sam Ravnborg
2019-01-30 14:37 ` Brajeswar Ghosh
2019-01-30 15:15 ` Souptick Joarder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox