From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEA9DC43387 for ; Wed, 26 Dec 2018 22:39:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C3592054F for ; Wed, 26 Dec 2018 22:39:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545863963; bh=rwW6liGd2+TjXxUHh5/IIl1hEyqKxR6O6VJEmWv7MDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YRFIjbFWOggjdyTcne9xV7lNl+Zps53+7fF7bhxGu3cZZm2PRCTWOyu6QTTIgOiFJ +kGhW8sdpvW2nLLLAaKxveQvfy2l6UfhHHGXJAqFq5HhL/IHb5FA3tUhT3t4XlSjIn Ss+SqLsZQlI6NolGyyOH0B1woBfuw7E3sYkGBilg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727989AbeLZWjW (ORCPT ); Wed, 26 Dec 2018 17:39:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:38838 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728833AbeLZWif (ORCPT ); Wed, 26 Dec 2018 17:38:35 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 13C0D20651; Wed, 26 Dec 2018 22:38:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545863914; bh=rwW6liGd2+TjXxUHh5/IIl1hEyqKxR6O6VJEmWv7MDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U2hkfaKQcZHOW8+krT5CesyLWpaZtviKJB+u+OKlzk62dKzRe/zBWs57Wn5pOG55t fWa0N51xHfRogdSB8wnQRVYFk9lZLkueNPgkRkAlVBen72QeE47cum4DgpoyDKhLJB rIsA4nmpQqFmvAadSxrDpuTnecdmjOM09+PP6yQU= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Kangjie Lu , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 93/97] net: netxen: fix a missing check and an uninitialized use Date: Wed, 26 Dec 2018 17:35:53 -0500 Message-Id: <20181226223557.149329-93-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181226223557.149329-1-sashal@kernel.org> References: <20181226223557.149329-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kangjie Lu [ Upstream commit d134e486e831defd26130770181f01dfc6195f7d ] When netxen_rom_fast_read() fails, "bios" is left uninitialized and may contain random value, thus should not be used. The fix ensures that if netxen_rom_fast_read() fails, we return "-EIO". Signed-off-by: Kangjie Lu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c index 0ea141ece19e..6547a9dd5935 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c @@ -1125,7 +1125,8 @@ netxen_validate_firmware(struct netxen_adapter *adapter) return -EINVAL; } val = nx_get_bios_version(adapter); - netxen_rom_fast_read(adapter, NX_BIOS_VERSION_OFFSET, (int *)&bios); + if (netxen_rom_fast_read(adapter, NX_BIOS_VERSION_OFFSET, (int *)&bios)) + return -EIO; if ((__force u32)val != bios) { dev_err(&pdev->dev, "%s: firmware bios is incompatible\n", fw_name[fw_type]); -- 2.19.1