From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F11ADC43387 for ; Wed, 26 Dec 2018 22:44:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA317214D8 for ; Wed, 26 Dec 2018 22:44:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545864273; bh=Sg1iBYZtDcjdQC3hW8acxEPqpkVOymZLaR0ZUHbzK5M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jMQUB43XfLgWxFIllbUO63txGihDqc1c+VjN0rYrrO3dJDV+FLxEs3/9yH5WTSd+x EpEYSfayuDTsFFSWyTV6EeDxb/DSgBQE3L7pMY/yviYx+Ls+Y0OiwfIkiqE3SIZedm 8z1rcJBwaMwMzmZuiOQn+XE8KbGU+MGEANg5Cg7I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729702AbeLZWoc (ORCPT ); Wed, 26 Dec 2018 17:44:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:41060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729203AbeLZWkq (ORCPT ); Wed, 26 Dec 2018 17:40:46 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 708BF20651; Wed, 26 Dec 2018 22:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545864045; bh=Sg1iBYZtDcjdQC3hW8acxEPqpkVOymZLaR0ZUHbzK5M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JEy5lbdJZj34yPSav4LmR7GHoVhCNIN7lw71reFHrrMkmIvm6qoeXeprJVMddPq6l uCOM57YI+5cKqvXwE4pIzi0Xln+or9FuNAdtDcXFidggDe18rhBCgophgUNXezDypz aGPBQcUn2a7L7iu1sI0JvYPdz2qZH4/IXuDbRfDI= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Arnd Bergmann , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 31/59] w90p910_ether: remove incorrect __init annotation Date: Wed, 26 Dec 2018 17:38:11 -0500 Message-Id: <20181226223839.150262-31-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181226223839.150262-1-sashal@kernel.org> References: <20181226223839.150262-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann [ Upstream commit 51367e423c6501a26e67d91a655d2bc892303462 ] The get_mac_address() function is normally inline, but when it is not, we get a warning that this configuration is broken: WARNING: vmlinux.o(.text+0x4aff00): Section mismatch in reference from the function w90p910_ether_setup() to the function .init.text:get_mac_address() The function w90p910_ether_setup() references the function __init get_mac_address(). This is often because w90p910_ether_setup lacks a __init Remove the __init to make it always do the right thing. Signed-off-by: Arnd Bergmann Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/nuvoton/w90p910_ether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/nuvoton/w90p910_ether.c b/drivers/net/ethernet/nuvoton/w90p910_ether.c index 4a67c55aa9f1..11a9add81849 100644 --- a/drivers/net/ethernet/nuvoton/w90p910_ether.c +++ b/drivers/net/ethernet/nuvoton/w90p910_ether.c @@ -912,7 +912,7 @@ static const struct net_device_ops w90p910_ether_netdev_ops = { .ndo_validate_addr = eth_validate_addr, }; -static void __init get_mac_address(struct net_device *dev) +static void get_mac_address(struct net_device *dev) { struct w90p910_ether *ether = netdev_priv(dev); struct platform_device *pdev; -- 2.19.1