From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F9BC43387 for ; Wed, 26 Dec 2018 22:57:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44C44214D8 for ; Wed, 26 Dec 2018 22:57:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545865030; bh=XxizODUI1F7/s8z+eQDlB3Yv+AUspEEwsNimYGeI5rQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=U6vibmiSHMPrRXDdGPxiSKlvA7PKGTs0B72wmuPF4AftbU6yDAaf2KUd4JlObYUrK 2vu8myKyoiPBi4orjjgQFg19g07iWMpmUPa8wwHS7aN0Miy9YVEMEBlNc0rz0p19zx Q3mPupp3Ev+0kwT4BJQ/DVPX4BkRnipYNTveo9Zc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730395AbeLZW5I (ORCPT ); Wed, 26 Dec 2018 17:57:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:58008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730364AbeLZW5G (ORCPT ); Wed, 26 Dec 2018 17:57:06 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A810A20651; Wed, 26 Dec 2018 22:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545865025; bh=XxizODUI1F7/s8z+eQDlB3Yv+AUspEEwsNimYGeI5rQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SotppU7AWz4Y48sgTsquz8ocZu0uS5H77frQzjUsavgxSwewVKzs2GGLC27wvbZy/ tUk9dX4MJ9lVF22rxxPWVOP6g/ASRTd7zhT9487wq11Td4QjXXRVSvWJ181qq/VWzB 0gm1JIgR75p496OVVoDSOaeqJ0JYzK5isy95usgE= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dan Carpenter , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 06/21] scsi: bnx2fc: Fix NULL dereference in error handling Date: Wed, 26 Dec 2018 17:54:44 -0500 Message-Id: <20181226225501.151365-6-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181226225501.151365-1-sashal@kernel.org> References: <20181226225501.151365-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 9ae4f8420ed7be4b13c96600e3568c144d101a23 ] If "interface" is NULL then we can't release it and trying to will only lead to an Oops. Fixes: aea71a024914 ("[SCSI] bnx2fc: Introduce interface structure for each vlan interface") Signed-off-by: Dan Carpenter Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index d0b227ffbd5f..573aeec7a02b 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c @@ -2279,7 +2279,7 @@ static int _bnx2fc_create(struct net_device *netdev, if (!interface) { printk(KERN_ERR PFX "bnx2fc_interface_create failed\n"); rc = -ENOMEM; - goto ifput_err; + goto netdev_err; } if (netdev->priv_flags & IFF_802_1Q_VLAN) { -- 2.19.1