* [PATCH] char: hw_random: Fix missing check during driver release
@ 2018-12-26 17:23 Aditya Pakki
2018-12-26 17:44 ` Michael S. Tsirkin
2018-12-26 22:03 ` Michael Büsch
0 siblings, 2 replies; 3+ messages in thread
From: Aditya Pakki @ 2018-12-26 17:23 UTC (permalink / raw)
To: pakki001
Cc: kjlu, Matt Mackall, Herbert Xu, Arnd Bergmann, Greg Kroah-Hartman,
Michael Buesch, Michael S. Tsirkin, linux-crypto, linux-kernel
devres_release can return -ENOENT if the device is not freed. The fix
throws a warning consistent with other invocations.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
drivers/char/hw_random/core.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index 95be7228f327..582d983fa93f 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -578,7 +578,11 @@ EXPORT_SYMBOL_GPL(devm_hwrng_register);
void devm_hwrng_unregister(struct device *dev, struct hwrng *rng)
{
- devres_release(dev, devm_hwrng_release, devm_hwrng_match, rng);
+ int rc;
+
+ rc = devres_release(dev, devm_hwrng_release, devm_hwrng_match, rng);
+ if (rc)
+ WARN_ON(rc);
}
EXPORT_SYMBOL_GPL(devm_hwrng_unregister);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] char: hw_random: Fix missing check during driver release
2018-12-26 17:23 [PATCH] char: hw_random: Fix missing check during driver release Aditya Pakki
@ 2018-12-26 17:44 ` Michael S. Tsirkin
2018-12-26 22:03 ` Michael Büsch
1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2018-12-26 17:44 UTC (permalink / raw)
To: Aditya Pakki
Cc: kjlu, Matt Mackall, Herbert Xu, Arnd Bergmann, Greg Kroah-Hartman,
Michael Buesch, linux-crypto, linux-kernel
On Wed, Dec 26, 2018 at 11:23:31AM -0600, Aditya Pakki wrote:
> devres_release can return -ENOENT if the device is not freed. The fix
> throws a warning consistent with other invocations.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Well why not
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/char/hw_random/core.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
> index 95be7228f327..582d983fa93f 100644
> --- a/drivers/char/hw_random/core.c
> +++ b/drivers/char/hw_random/core.c
> @@ -578,7 +578,11 @@ EXPORT_SYMBOL_GPL(devm_hwrng_register);
>
> void devm_hwrng_unregister(struct device *dev, struct hwrng *rng)
> {
> - devres_release(dev, devm_hwrng_release, devm_hwrng_match, rng);
> + int rc;
> +
> + rc = devres_release(dev, devm_hwrng_release, devm_hwrng_match, rng);
> + if (rc)
> + WARN_ON(rc);
> }
> EXPORT_SYMBOL_GPL(devm_hwrng_unregister);
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] char: hw_random: Fix missing check during driver release
2018-12-26 17:23 [PATCH] char: hw_random: Fix missing check during driver release Aditya Pakki
2018-12-26 17:44 ` Michael S. Tsirkin
@ 2018-12-26 22:03 ` Michael Büsch
1 sibling, 0 replies; 3+ messages in thread
From: Michael Büsch @ 2018-12-26 22:03 UTC (permalink / raw)
To: Aditya Pakki
Cc: kjlu, Matt Mackall, Herbert Xu, Arnd Bergmann, Greg Kroah-Hartman,
Michael S. Tsirkin, linux-crypto, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]
On Wed, 26 Dec 2018 11:23:31 -0600
Aditya Pakki <pakki001@umn.edu> wrote:
> devres_release can return -ENOENT if the device is not freed. The fix
> throws a warning consistent with other invocations.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> drivers/char/hw_random/core.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
> index 95be7228f327..582d983fa93f 100644
> --- a/drivers/char/hw_random/core.c
> +++ b/drivers/char/hw_random/core.c
> @@ -578,7 +578,11 @@ EXPORT_SYMBOL_GPL(devm_hwrng_register);
>
> void devm_hwrng_unregister(struct device *dev, struct hwrng *rng)
> {
> - devres_release(dev, devm_hwrng_release, devm_hwrng_match, rng);
> + int rc;
> +
> + rc = devres_release(dev, devm_hwrng_release, devm_hwrng_match, rng);
> + if (rc)
The if statement is redundant and can be removed.
> + WARN_ON(rc);
> }
> EXPORT_SYMBOL_GPL(devm_hwrng_unregister);
>
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-26 22:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-26 17:23 [PATCH] char: hw_random: Fix missing check during driver release Aditya Pakki
2018-12-26 17:44 ` Michael S. Tsirkin
2018-12-26 22:03 ` Michael Büsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox