From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: NeilBrown <neil@brown.name>
Cc: Randy Dunlap <rdunlap@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH v3 treewide] headers: separate linux/mod_devicetable.h from linux/platform_device.h
Date: Sat, 29 Dec 2018 13:23:47 +0100 [thread overview]
Message-ID: <20181229122347.GA24413@kroah.com> (raw)
In-Reply-To: <871s61azip.fsf@notabene.neil.brown.name>
On Sat, Dec 29, 2018 at 12:32:30PM +1100, NeilBrown wrote:
> On Sat, Jul 07 2018, Greg Kroah-Hartman wrote:
>
> > On Tue, Jun 19, 2018 at 10:47:28PM -0700, Randy Dunlap wrote:
> >> From: Randy Dunlap <rdunlap@infradead.org>
> >>
> >> At over 4000 #includes, <linux/platform_device.h> is the 9th most
> >> #included header file in the Linux kernel. It does not need
> >> <linux/mod_devicetable.h>, so drop that header and explicitly add
> >> <linux/mod_devicetable.h> to source files that need it.
> >>
> >> 4146 #include <linux/platform_device.h>
> >>
> >> After this patch, there are 225 files that use <linux/mod_devicetable.h>,
> >> for a reduction of around 3900 times that <linux/mod_devicetable.h>
> >> does not have to be read & parsed.
> >>
> >> 225 #include <linux/mod_devicetable.h>
> >>
> >> This patch was build-tested on 20 different arch-es.
> >>
> >> It also makes these drivers SubmitChecklist#1 compliant.
> >>
> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> >> Reported-by: kbuild test robot <lkp@intel.com> # drivers/media/platform/vimc/
> >> Reported-by: kbuild test robot <lkp@intel.com> # drivers/pinctrl/pinctrl-u300.c
> >> ---
> >> v3: add fix for drivers/pinctrl/pinctrl-u300.c
> >> v2: add fixes for drivers/media/platform/vimc/
> >
> > I've queued this up now, let's see what else breaks! :)
>
> Some MIPS watchdog drivers break, at least.
>
> NeilBrown
>
> From: NeilBrown <neil@brown.name>
> Subject: [PATCH] Fix compilation problem for mt7621_wdt.c and rt2880_wdt.c
>
> These files need
> #include <linux/mod_devicetable.h>
> to compile correctly.
>
> Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")
> Signed-off-by: NeilBrown <neil@brown.name>
> ---
> drivers/watchdog/mt7621_wdt.c | 1 +
> drivers/watchdog/rt2880_wdt.c | 1 +
> 2 files changed, 2 insertions(+)
Great, can you send these to the watchdog maintainer to queue up?
thanks,
greg k-h
prev parent reply other threads:[~2018-12-29 12:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 5:47 [PATCH v3 treewide] headers: separate linux/mod_devicetable.h from linux/platform_device.h Randy Dunlap
2018-07-07 15:53 ` Greg Kroah-Hartman
2018-12-29 1:32 ` NeilBrown
2018-12-29 2:10 ` Randy Dunlap
2018-12-29 12:23 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181229122347.GA24413@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=neil@brown.name \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox