From: Sam Ravnborg <sam@ravnborg.org>
To: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Sean Paul <sean@poorly.run>, David Lechner <david@lechnology.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH v2 0/14] drm: minimize drmP.h dependencies
Date: Sun, 30 Dec 2018 18:48:24 +0100 [thread overview]
Message-ID: <20181230174838.32330-1-sam@ravnborg.org> (raw)
The goal with this small series is to remove the last bits
that prevents us from removing drmP.h driver-by-driver or file by file.
- drmP.h is now stripped down to include files and forward declarations.
- All header files in include/drm/ no longer include drmP.h.
The series was made on top of drm-misc-next
Build tested using arm and x86 all{yes,mod}config
The patches are trivial but touches a lot of files,
so a lot of people on cc: for the individual patches.
I expect the full series to be applied to drm-misc-next
There are still ~700 uses of drmP.h so a long way ahead of
us to get rid of it.
(The last mail said 900 but that was a typo)
The kernel-doc parts that I authored in the following
may require some extra info as I know too little about
DRM to be able to write something really useful.
Or at least review by someone with knowledge of DRM,
but that goes for everything.
v2:
- DRM_SWITCH_POWER as enum (Daniel Vetter)
- Prefer forward decalration over includes (Laurent Pinchart)
- Updated drm_device to use kerneldoc style (Daniel Vetter)
- Improved commit messages (David Lechner)
- Split up patch when removing drmP.h from drm_gem_cma_helper.h
- rebased on top of drm-misc-next
- dropped patch already applied
- added reviewed-by from Laurent Pinchart (Laurent Pinchart)
- add drm_framebuffer.h patch
- add kernel-doc comments to drm_util.h
- moved EXPORT_SYMBOL_FOR_TESTS_ONLY to drm_util.h
- added note to drmP.h not to add new stuff and not to use in new files
Sam
Sam Ravnborg (14):
drm: drm_device.h: update comments to kerneldoc style
drm: move DRM_SWITCH_POWER defines to drm_device.h
drm: make drm_framebuffer.h self contained
drm: make drm_file.h self contained
drm: move drm_can_sleep() to drm_util.h
drm: add kernel-doc comments to drm_util.h
drm: move EXPORT_SYMBOL_FOR_TESTS_ONLY to drm_util.h
drm: remove include of drmP.h from bridge/dw_hdmi.h
drm: remove include of drmP.h from drm_encoder_slave.h
drm: remove include of drmP.h from drm_modeset_helper.h
drm/arc: do not reply on drmP.h from drm_gem_cma_helper.h
drm/stm: do not reply on drmP.h from drm_gem_cma_helper.h
drm/tinydrm: do not reply on drmP.h from drm_gem_cma_helper.h
drm: remove drmP.h from drm_gem_cma_helper.h
drivers/gpu/drm/amd/amdgpu/atom.c | 2 +
drivers/gpu/drm/arc/arcpgu_crtc.c | 2 +
drivers/gpu/drm/arc/arcpgu_drv.c | 6 +
drivers/gpu/drm/arc/arcpgu_sim.c | 1 +
drivers/gpu/drm/ast/ast_fb.c | 2 +
drivers/gpu/drm/bridge/cdns-dsi.c | 2 +
.../gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c | 4 +
drivers/gpu/drm/cirrus/cirrus_fbdev.c | 1 +
drivers/gpu/drm/drm_flip_work.c | 1 +
drivers/gpu/drm/drm_framebuffer.c | 1 +
drivers/gpu/drm/drm_modeset_helper.c | 2 +
drivers/gpu/drm/mgag200/mgag200_fb.c | 1 +
drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c | 1 +
drivers/gpu/drm/omapdrm/omap_fbdev.c | 1 +
drivers/gpu/drm/qxl/qxl_cmd.c | 2 +
drivers/gpu/drm/radeon/atom.c | 2 +
drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 1 +
drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 1 +
drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
drivers/gpu/drm/stm/drv.c | 6 +-
drivers/gpu/drm/stm/ltdc.c | 9 +-
drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 3 +
drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 3 +
drivers/gpu/drm/tinydrm/hx8357d.c | 1 +
drivers/gpu/drm/tinydrm/ili9225.c | 2 +
drivers/gpu/drm/tinydrm/ili9341.c | 1 +
drivers/gpu/drm/tinydrm/mi0283qt.c | 1 +
drivers/gpu/drm/tinydrm/mipi-dbi.c | 3 +
drivers/gpu/drm/tinydrm/repaper.c | 1 +
drivers/gpu/drm/tinydrm/st7586.c | 1 +
drivers/gpu/drm/tinydrm/st7735r.c | 1 +
drivers/gpu/drm/vc4/vc4_drv.h | 1 +
include/drm/bridge/dw_hdmi.h | 6 +-
include/drm/drmP.h | 24 +--
include/drm/drm_device.h | 228 +++++++++++++++------
include/drm/drm_encoder_slave.h | 1 -
include/drm/drm_file.h | 1 +
include/drm/drm_framebuffer.h | 5 +-
include/drm/drm_gem_cma_helper.h | 5 +-
include/drm/drm_modeset_helper.h | 6 +-
include/drm/drm_util.h | 49 ++++-
41 files changed, 299 insertions(+), 93 deletions(-)
next reply other threads:[~2018-12-30 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 17:48 Sam Ravnborg [this message]
2018-12-30 19:08 ` [PATCH v2 0/14] drm: minimize drmP.h dependencies Sam Ravnborg
2018-12-30 19:32 ` Randy Dunlap
2018-12-30 20:37 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181230174838.32330-1-sam@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=david@lechnology.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox