From: Dan Carpenter <dan.carpenter@oracle.com>
To: Aditya Pakki <pakki001@umn.edu>
Cc: devel@driverdev.osuosl.org, Kees Cook <keescook@chromium.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kjlu@umn.edu, linux-kernel@vger.kernel.org,
Aymen Qader <qader.aymen@gmail.com>
Subject: Re: [PATCH] staging: rts5208: Add a check for ms_read_extra_data
Date: Wed, 2 Jan 2019 13:50:59 +0300 [thread overview]
Message-ID: <20190102105058.GH3781@kadam> (raw)
In-Reply-To: <20181227193554.25448-1-pakki001@umn.edu>
On Thu, Dec 27, 2018 at 01:35:53PM -0600, Aditya Pakki wrote:
> In ms_copy_page, the function ms_read_extra_data may fail for many
> reasons. The fix adds a check similar to other invocation to return
> error upstream.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Yup. It doesn't make sense to use stale "extra" data.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
prev parent reply other threads:[~2019-01-02 10:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 19:35 [PATCH] staging: rts5208: Add a check for ms_read_extra_data Aditya Pakki
2019-01-02 10:50 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190102105058.GH3781@kadam \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=qader.aymen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox