* [PATCH] staging: rts5208: Add a check for ms_read_extra_data
@ 2018-12-27 19:35 Aditya Pakki
2019-01-02 10:50 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Pakki @ 2018-12-27 19:35 UTC (permalink / raw)
To: pakki001
Cc: kjlu, Greg Kroah-Hartman, Dan Carpenter, Kees Cook, Aymen Qader,
Arnd Bergmann, devel, linux-kernel
In ms_copy_page, the function ms_read_extra_data may fail for many
reasons. The fix adds a check similar to other invocation to return
error upstream.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
drivers/staging/rts5208/ms.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index 04b588b8b376..8eb6221e4cc8 100644
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -1676,7 +1676,10 @@ static int ms_copy_page(struct rtsx_chip *chip, u16 old_blk, u16 new_blk,
return STATUS_FAIL;
}
- ms_read_extra_data(chip, old_blk, i, extra, MS_EXTRA_SIZE);
+ retval = ms_read_extra_data(chip, old_blk, i, extra,
+ MS_EXTRA_SIZE);
+ if (retval != STATUS_SUCCESS)
+ return STATUS_FAIL;
retval = ms_set_rw_reg_addr(chip, OverwriteFlag,
MS_EXTRA_SIZE, SystemParm, 6);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rts5208: Add a check for ms_read_extra_data
2018-12-27 19:35 [PATCH] staging: rts5208: Add a check for ms_read_extra_data Aditya Pakki
@ 2019-01-02 10:50 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2019-01-02 10:50 UTC (permalink / raw)
To: Aditya Pakki
Cc: devel, Kees Cook, Arnd Bergmann, Greg Kroah-Hartman, kjlu,
linux-kernel, Aymen Qader
On Thu, Dec 27, 2018 at 01:35:53PM -0600, Aditya Pakki wrote:
> In ms_copy_page, the function ms_read_extra_data may fail for many
> reasons. The fix adds a check similar to other invocation to return
> error upstream.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Yup. It doesn't make sense to use stale "extra" data.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-02 10:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-27 19:35 [PATCH] staging: rts5208: Add a check for ms_read_extra_data Aditya Pakki
2019-01-02 10:50 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox