Re: [PATCH v5 02/11] ata: pata_acpi: Make PCI dependency explicit

Jens Axboe
2019-01-07T15:42:02Z

On 1/7/19 7:17 AM, Bartlomiej Zolnierkiewicz wrote:
>
> On 01/07/2019 12:12 PM, Rafael J. Wysocki wrote:
>> On Wed, Jan 2, 2019 at 7:11 PM Sinan Kaya <okaya@kernel.org> wrote:
>>>
>>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
>>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
>>> satisfied implicitly through dependencies on CONFIG_ACPI have to be
>>> specified directly. PATA_ACPI is a PCI device driver but the PCI
>>> dependency has not been explicitly called out.
>>>
>>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
>>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>>> ---
>>> drivers/ata/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
>>> index 4ca7a6b4eaae..8218db17ebdb 100644
>>> --- a/drivers/ata/Kconfig
>>> +++ b/drivers/ata/Kconfig
>>> @@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
>>>
>>> config PATA_ACPI
>>> tristate "ACPI firmware driver for PATA"
>>> - depends on ATA_ACPI && ATA_BMDMA
>>> + depends on ATA_ACPI && ATA_BMDMA && PCI
>>> help
>>> This option enables an ACPI method driver which drives
>>> motherboard PATA controller interfaces through the ACPI
>>> --
>>
>> Any objections against this one from anyone?
>
> Patch looks correct to me (pata_acpi is indeed a PCI driver):
>
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>
> but it is best to wait for Jens' ACK if you want to merge it
> through ACPI tree..

You can add my:

Reviewed-by: Jens Axboe <axboe@kernel.dk>

if you want to merge it through the ACPI tree.

--
Jens Axboe