* [PATCH] infiniband: bnxt_re: qplib: Check the return value of send_message
@ 2018-12-26 18:56 Aditya Pakki
2018-12-31 6:09 ` Devesh Sharma
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Aditya Pakki @ 2018-12-26 18:56 UTC (permalink / raw)
To: pakki001
Cc: kjlu, Selvin Xavier, Devesh Sharma, Somnath Kotur,
Sriharsha Basavapatna, Doug Ledford, Jason Gunthorpe, linux-rdma,
linux-kernel
In bnxt_qplib_map_tc2cos(), bnxt_qplib_rcfw_send_message() can return
an error value. The fix returns the error from the latter function
upstream.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
drivers/infiniband/hw/bnxt_re/qplib_sp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.c b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
index 5216b5f844cc..adb8eae5193c 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_sp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
@@ -778,9 +778,8 @@ int bnxt_qplib_map_tc2cos(struct bnxt_qplib_res *res, u16 *cids)
req.cos0 = cpu_to_le16(cids[0]);
req.cos1 = cpu_to_le16(cids[1]);
- bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp, NULL,
- 0);
- return 0;
+ return bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp,
+ NULL, 0);
}
int bnxt_qplib_get_roce_stats(struct bnxt_qplib_rcfw *rcfw,
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] infiniband: bnxt_re: qplib: Check the return value of send_message
2018-12-26 18:56 [PATCH] infiniband: bnxt_re: qplib: Check the return value of send_message Aditya Pakki
@ 2018-12-31 6:09 ` Devesh Sharma
2019-01-01 7:52 ` Leon Romanovsky
2019-01-02 23:06 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Devesh Sharma @ 2018-12-31 6:09 UTC (permalink / raw)
To: Aditya Pakki
Cc: kjlu, Selvin Xavier, Somnath Kotur, Sriharsha Basavapatna,
Doug Ledford, Jason Gunthorpe, linux-rdma, LKML
On Thu, Dec 27, 2018 at 12:26 AM Aditya Pakki <pakki001@umn.edu> wrote:
>
> In bnxt_qplib_map_tc2cos(), bnxt_qplib_rcfw_send_message() can return
> an error value. The fix returns the error from the latter function
> upstream.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> drivers/infiniband/hw/bnxt_re/qplib_sp.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.c b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> index 5216b5f844cc..adb8eae5193c 100644
> --- a/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> +++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> @@ -778,9 +778,8 @@ int bnxt_qplib_map_tc2cos(struct bnxt_qplib_res *res, u16 *cids)
> req.cos0 = cpu_to_le16(cids[0]);
> req.cos1 = cpu_to_le16(cids[1]);
>
> - bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp, NULL,
> - 0);
> - return 0;
> + return bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp,
> + NULL, 0);
> }
>
> int bnxt_qplib_get_roce_stats(struct bnxt_qplib_rcfw *rcfw,
> --
> 2.17.1
>
Acked-By: Devesh Sharma <devesh.sharma@broadcom.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] infiniband: bnxt_re: qplib: Check the return value of send_message
2018-12-26 18:56 [PATCH] infiniband: bnxt_re: qplib: Check the return value of send_message Aditya Pakki
2018-12-31 6:09 ` Devesh Sharma
@ 2019-01-01 7:52 ` Leon Romanovsky
2019-01-02 23:06 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Leon Romanovsky @ 2019-01-01 7:52 UTC (permalink / raw)
To: Aditya Pakki
Cc: kjlu, Selvin Xavier, Devesh Sharma, Somnath Kotur,
Sriharsha Basavapatna, Doug Ledford, Jason Gunthorpe, linux-rdma,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]
On Wed, Dec 26, 2018 at 12:56:22PM -0600, Aditya Pakki wrote:
> In bnxt_qplib_map_tc2cos(), bnxt_qplib_rcfw_send_message() can return
> an error value. The fix returns the error from the latter function
> upstream.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> drivers/infiniband/hw/bnxt_re/qplib_sp.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.c b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> index 5216b5f844cc..adb8eae5193c 100644
> --- a/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> +++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> @@ -778,9 +778,8 @@ int bnxt_qplib_map_tc2cos(struct bnxt_qplib_res *res, u16 *cids)
> req.cos0 = cpu_to_le16(cids[0]);
> req.cos1 = cpu_to_le16(cids[1]);
>
> - bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp, NULL,
> - 0);
> - return 0;
> + return bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp,
> + NULL, 0);
> }
AFAIK, there is no need to do casting to/from void*.
Thanks
>
> int bnxt_qplib_get_roce_stats(struct bnxt_qplib_rcfw *rcfw,
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] infiniband: bnxt_re: qplib: Check the return value of send_message
2018-12-26 18:56 [PATCH] infiniband: bnxt_re: qplib: Check the return value of send_message Aditya Pakki
2018-12-31 6:09 ` Devesh Sharma
2019-01-01 7:52 ` Leon Romanovsky
@ 2019-01-02 23:06 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2019-01-02 23:06 UTC (permalink / raw)
To: Aditya Pakki
Cc: kjlu, Selvin Xavier, Devesh Sharma, Somnath Kotur,
Sriharsha Basavapatna, Doug Ledford, linux-rdma, linux-kernel
On Wed, Dec 26, 2018 at 12:56:22PM -0600, Aditya Pakki wrote:
> In bnxt_qplib_map_tc2cos(), bnxt_qplib_rcfw_send_message() can return
> an error value. The fix returns the error from the latter function
> upstream.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> Acked-By: Devesh Sharma <devesh.sharma@broadcom.com>
> ---
> drivers/infiniband/hw/bnxt_re/qplib_sp.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Applied to for-next
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-02 23:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-26 18:56 [PATCH] infiniband: bnxt_re: qplib: Check the return value of send_message Aditya Pakki
2018-12-31 6:09 ` Devesh Sharma
2019-01-01 7:52 ` Leon Romanovsky
2019-01-02 23:06 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox