From: Mark Brown <broonie@kernel.org>
To: b-ak <anur.bhargav@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: tlv320aic32x4: Kernel OOPS while entering DAPM standby mode
Date: Thu, 3 Jan 2019 12:45:54 +0000 [thread overview]
Message-ID: <20190103124554.GS1846@sirena.org.uk> (raw)
In-Reply-To: <20190102170633.GA9724@Ideapad-330S>
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
On Wed, Jan 02, 2019 at 10:36:33PM +0530, b-ak wrote:
> During the bootup of the kernel, as soon as the DAPM framework kicks in
> it pushes the codec into standy mode.
>
> The existing TVL320AIC32x4 codec driver doesn't prepare the clock in
> the probe function.
> This leads to an OOPS when the DAPM tries to put it into standy by calling
> clk_disable_unprepare()
>
> This patch fixes that problem.
This isn't the best way of fixing this because it makes it look like
there's a missing disable in the removal process. What would be better
would be to do what other drivers do and check to see what state we're
transitioning from before we disable the clock in set_bias_level(). See
drivers like wm8903.c for examples.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-03 12:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 17:06 [PATCH] ASoC: tlv320aic32x4: Kernel OOPS while entering DAPM standby mode b-ak
2019-01-03 12:45 ` Mark Brown [this message]
2019-01-03 19:34 ` b-ak
2019-01-04 16:40 ` b-ak
2019-01-05 4:46 ` b-ak
2019-01-07 12:59 ` Mark Brown
2019-01-07 17:40 ` b-ak
2019-01-07 17:45 ` [PATCH v2] " b-ak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103124554.GS1846@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=anur.bhargav@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox