From: Cornelia Huck <cohuck@redhat.com>
To: "Michael S . Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, virtio-dev@lists.oasis-open.org,
Wei Wang <wei.w.wang@intel.com>,
Halil Pasic <pasic@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>
Subject: [PATCH 2/2] virtio: document virtio_config_ops restrictions
Date: Thu, 3 Jan 2019 17:08:04 +0100 [thread overview]
Message-ID: <20190103160804.21438-3-cohuck@redhat.com> (raw)
In-Reply-To: <20190103160804.21438-1-cohuck@redhat.com>
Some transports (e.g. virtio-ccw) implement virtio operations that
seem to be a simple read/write as something more involved that
cannot be done from an atomic context.
Give at least a hint about that.
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
include/linux/virtio_config.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
index 7087ef946ba7..987b6491b946 100644
--- a/include/linux/virtio_config.h
+++ b/include/linux/virtio_config.h
@@ -12,6 +12,11 @@ struct irq_affinity;
/**
* virtio_config_ops - operations for configuring a virtio device
+ * Note: Do not assume that a transport implements all of the operations
+ * getting/setting a value as a simple read/write! Generally speaking,
+ * any of @get/@set, @get_status/@set_status, or @get_features/
+ * @finalize_features are NOT safe to be called from an atomic
+ * context.
* @get: read the value of a configuration field
* vdev: the virtio_device
* offset: the offset of the configuration field
--
2.17.2
next prev parent reply other threads:[~2019-01-03 16:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 16:08 [PATCH 0/2] virtio: virtio_config_ops documentation Cornelia Huck
2019-01-03 16:08 ` [PATCH 1/2] virtio: fix virtio_config_ops description Cornelia Huck
2019-01-14 14:09 ` Cornelia Huck
2019-01-14 14:57 ` [virtio-dev] " Halil Pasic
2019-01-15 2:15 ` Wei Wang
2019-01-15 2:20 ` Michael S. Tsirkin
2019-01-03 16:08 ` Cornelia Huck [this message]
2019-01-03 16:28 ` [PATCH 2/2] virtio: document virtio_config_ops restrictions Michael S. Tsirkin
2019-01-04 12:39 ` Cornelia Huck
2019-01-03 17:28 ` Halil Pasic
2019-01-04 12:48 ` Cornelia Huck
2019-01-15 2:18 ` [virtio-dev] " Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103160804.21438-3-cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox