From: Christoph Hellwig <hch@infradead.org>
To: "Lulina (A)" <lina.lulina@huawei.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>, "hch@lst.de" <hch@lst.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v2] nvme-pci: fix dbbuf_sq_db point to freed memory
Date: Fri, 4 Jan 2019 10:07:10 -0800 [thread overview]
Message-ID: <20190104180710.GA4642@infradead.org> (raw)
In-Reply-To: <E5D59058E6941147BD3ACF9CB4AA49E3B3572EC2@DGGEMA505-MBX.china.huawei.com>
On Fri, Dec 21, 2018 at 01:07:25AM +0000, Lulina (A) wrote:
> The case is that nvme device support NVME_CTRL_OACS_DBBUF_SUPP, and
> return failed when the driver sent nvme_admin_dbbuf. The nvmeq->dbbuf_sq_db
> point to freed memory, as nvme_dbbuf_set is called after nvme_dbbuf_init.
But we never use those pointers in that state, do we? Can you explain
the problem in a little more detail?
next prev parent reply other threads:[~2019-01-04 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 1:07 [PATCH v2] nvme-pci: fix dbbuf_sq_db point to freed memory Lulina (A)
2019-01-04 18:07 ` Christoph Hellwig [this message]
2019-01-07 5:27 ` Lulina (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104180710.GA4642@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=lina.lulina@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox