From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFE0CC43387 for ; Fri, 4 Jan 2019 20:13:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA05E21874 for ; Fri, 4 Jan 2019 20:13:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726097AbfADUNA (ORCPT ); Fri, 4 Jan 2019 15:13:00 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:58591 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbfADUM7 (ORCPT ); Fri, 4 Jan 2019 15:12:59 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 5BB9380813; Fri, 4 Jan 2019 21:12:52 +0100 (CET) Date: Fri, 4 Jan 2019 21:12:56 +0100 From: Pavel Machek To: Jacek Anaszewski Cc: Vesa =?iso-8859-1?B?SuTkc2tlbORpbmVu?= , Dan Murphy , robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver Message-ID: <20190104201256.GA2931@amd> References: <8740cfd6-a6b5-ad27-313b-984a9febf18a@ti.com> <20181219201047.GA23448@amd> <54f28115-0a7d-8e9c-3bec-6e91fb3981ec@gmail.com> <986b5105-2fdb-bd25-7c8a-ca8fd1ade821@gmail.com> <7f205102-e854-f1cb-cc03-1307d1cddc87@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="G4iJoqBmSsgzjUCe" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --G4iJoqBmSsgzjUCe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >I suppose if one would just make it an array of values (separated by > >space) and then one file with string array of color element names and on > >file with maximum value array it could be within those words. > > > >The it would be something like: > > > >$ echo "23 54 32" > color >=20 > Go ahead, but first convince Pavel, and then Greg :-) >=20 > I'd personally would not have much against, especially that the > list of values will not grow for that one like in case of old patch set > [0] where Pavel and Greg thwarted my similar attempt. Oh, you can get this past Pavel (and probably Greg) -- if you have a good reason. Performance is _not_ a good reason. You don't need to change LED color 50000 times a second. If you can demonstrate a reasonable design, where user selects color =66rom well-known RGB pallete and either kernel or library+kernel acts to set that color on the LED, we can talk. When user asks for white, it has to be white. Exact color temperature does not matter. When user asks for pink, it has to be pink. Again, exact color does not matter; different monitors display slightly different colors, too. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --G4iJoqBmSsgzjUCe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlwvvkgACgkQMOfwapXb+vLC5gCeJzY/t2GKL7z2FxsIPH/gnKYJ obgAn0oHvXGS41dRhGdbciUlflxl8+Rr =ywxG -----END PGP SIGNATURE----- --G4iJoqBmSsgzjUCe--