Re: [PATCH RFC] bluetooth: add uart h4 devices via serdev/devicetree

Andreas Kemnade
2018-11-12T20:59:47Z

[-- Attachment #1: Type: text/plain, Size: 931 bytes --]

Hi,

On Sun, 11 Nov 2018 03:46:48 +0100
Sebastian Reichel <sebastian.reichel@collabora.com> wrote:

> Hi,
>
> On Sun, Nov 11, 2018 at 12:20:34AM +0100, Andreas Kemnade wrote:
> > This is a first try to be able to use h4 devices specified in
> > the devicetree, so you do not need to call hciattach and
> > it can be automatically probed.
> >
> > Of course, proper devicetree bindings documentation is
> > missing. And also you would extend that by regulator/
> > enable gpio settings.
> >
> > But before proceeding further it should be checked if the
> > general way of doing things is right.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
>
> Patch looks good to me, just one note
>
I found one thing myself:
Shouldn't we have a generic compatible string like "generic-h4".
ehci-platform.c has for example:
{ .compatible = "generic-ehci", },

Regards,
Andreas

[-- Attachment #2: OpenPGP digital signature --]