From: Guenter Roeck <linux@roeck-us.net>
To: Fabio Estevam <festevam@gmail.com>
Cc: robdclark@gmail.com, jonathan@marek.ca,
dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org,
andy.gross@linaro.org, shawnguo@kernel.org, cphealy@gmail.com,
linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] qcom-scm: Include <linux/err.h> header
Date: Fri, 4 Jan 2019 13:15:37 -0800 [thread overview]
Message-ID: <20190104211537.GA19545@roeck-us.net> (raw)
In-Reply-To: <20181226120619.18879-1-festevam@gmail.com>
On Wed, Dec 26, 2018 at 10:06:19AM -0200, Fabio Estevam wrote:
> Since commit e6f6d63ed14c ("drm/msm: add headless gpu device for imx5")
> the DRM_MSM symbol can be selected by SOC_IMX5 causing the following
> error when building imx_v6_v7_defconfig:
>
> In file included from ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:17:0:
> ../include/linux/qcom_scm.h: In function 'qcom_scm_set_cold_boot_addr':
> ../include/linux/qcom_scm.h:73:10: error: 'ENODEV' undeclared (first use in this function)
> return -ENODEV;
>
> Include the <linux/err.h> header file to fix this problem.
>
> Reported-by: kernelci.org bot <bot@kernelci.org>
> Fixes: e6f6d63ed14c ("drm/msm: add headless gpu device for imx5")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Still broken upstream, and the commit window is about to close.
Any chance to send this patch upstream anytime soon ?
Guenter
> ---
> include/linux/qcom_scm.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h
> index 06996ad4f2bc..ce5a476fd733 100644
> --- a/include/linux/qcom_scm.h
> +++ b/include/linux/qcom_scm.h
> @@ -13,6 +13,7 @@
> #ifndef __QCOM_SCM_H
> #define __QCOM_SCM_H
>
> +#include <linux/err.h>
> #include <linux/types.h>
> #include <linux/cpumask.h>
>
parent reply other threads:[~2019-01-04 21:15 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20181226120619.18879-1-festevam@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104211537.GA19545@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=cphealy@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox