From: Jiri Olsa <jolsa@redhat.com>
To: "Jin, Yao" <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf stat: Poll for monitored tasks being alive in fork mode
Date: Sun, 6 Jan 2019 16:57:48 +0100 [thread overview]
Message-ID: <20190106155748.GD31228@krava> (raw)
In-Reply-To: <3ccf2565-c271-1cba-e5dc-7c33302cf417@linux.intel.com>
On Sun, Jan 06, 2019 at 10:02:18PM +0800, Jin, Yao wrote:
SNIP
> > ---
> > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> > index acfd48db52dd..c322cb271180 100644
> > --- a/tools/perf/builtin-stat.c
> > +++ b/tools/perf/builtin-stat.c
> > @@ -583,6 +583,14 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)
> > if (interval || timeout) {
> > while (!waitpid(child_pid, &status, WNOHANG)) {
> > + if (!is_target_alive(&target, evsel_list->threads)) {
> > + int pid = child_pid;
> > +
> > + if (pid != -1)
> > + kill(pid, SIGTERM);
> > + break;
> > + }
> > +
> > nanosleep(&ts, NULL);
> > if (timeout)
> > break;
> >
>
> Hi Jiri,
>
> I think your patch is good. At least, we can avoid the case of kill(-1,
> SIGTERM).
>
> BTW, you post this patch or I re-post it, both fine for me. :)
please post it
thanks,
jirka
prev parent reply other threads:[~2019-01-06 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 2:28 [PATCH] perf stat: Poll for monitored tasks being alive in fork mode Jin Yao
2019-01-04 12:54 ` Jiri Olsa
2019-01-05 3:16 ` Jin, Yao
2019-01-06 13:25 ` Jiri Olsa
2019-01-06 14:02 ` Jin, Yao
2019-01-06 15:57 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190106155748.GD31228@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox