From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91DF1C43387 for ; Mon, 7 Jan 2019 12:58:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5660B21736 for ; Mon, 7 Jan 2019 12:58:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546865881; bh=gKdpVSocoltwi2f1fVTfpaRQ40B0sfpGLCzKGayUAJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=aIxcsyZKjNJ5mdzvjGb/D6MAqx5JG6NnHTcXygrVPS+uR8yz8Tj04wO8xN7Fy8j/q yK89Vq3wRizFEeD3bubgOQaLKyQ0o2Q/etimjVmiIVDwn2Loqhz3/TX4h2JPl15gIK 13yfbbv4pHSTvlcOkg2RjKk8tGr7TjNA6E329t3U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729431AbfAGM6A (ORCPT ); Mon, 7 Jan 2019 07:58:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:45502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727856AbfAGM55 (ORCPT ); Mon, 7 Jan 2019 07:57:57 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D70FE2089F; Mon, 7 Jan 2019 12:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546865877; bh=gKdpVSocoltwi2f1fVTfpaRQ40B0sfpGLCzKGayUAJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y8TLt5yrkjHbfuRZFht8ZoFuEy7o+pNUnguBtqqWctVPOs/UEdRhzk5Jf/nWAtY7S qp85KvKQK6iHKgCFzTvU4Um4iGTXgpebJGnkm8XCUCDu3EtdN0X9U2HgBWjZrs5jYl qEGEHffpe4T6CHbjeZDxROztojeVLqstR8N06nhM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Greg Kurz , Frederic Barrat , Andrew Donnellan , Michael Ellerman Subject: [PATCH 4.19 106/170] ocxl: Fix endiannes bug in read_afu_name() Date: Mon, 7 Jan 2019 13:32:13 +0100 Message-Id: <20190107104505.452710786@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107104452.953560660@linuxfoundation.org> References: <20190107104452.953560660@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kurz commit 2f07229f02d4c55affccd11a61af4fd4b94dc436 upstream. The AFU Descriptor Template in the PCI config space has a Name Space field which is a 24 Byte ASCII character string of descriptive name space for the AFU. The OCXL driver read the string four characters at a time with pci_read_config_dword(). This optimization is valid on a little-endian system since this is PCI, but a big-endian system ends up with each subset of four characters in reverse order. This could be fixed by switching to read characters one by one. Another option is to swap the bytes if we're big-endian. Go for the latter with le32_to_cpu(). Cc: stable@vger.kernel.org # v4.16 Signed-off-by: Greg Kurz Acked-by: Frederic Barrat Acked-by: Andrew Donnellan Signed-off-by: Michael Ellerman Signed-off-by: Greg Kroah-Hartman --- drivers/misc/ocxl/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/misc/ocxl/config.c +++ b/drivers/misc/ocxl/config.c @@ -318,7 +318,7 @@ static int read_afu_name(struct pci_dev if (rc) return rc; ptr = (u32 *) &afu->name[i]; - *ptr = val; + *ptr = le32_to_cpu((__force __le32) val); } afu->name[OCXL_AFU_NAME_SZ - 1] = '\0'; /* play safe */ return 0;