From: Cornelia Huck <cohuck@redhat.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
Alex Williamson <alex.williamson@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>,
kvm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vfio_pci: Add local source directory as include
Date: Mon, 7 Jan 2019 12:12:24 +0100 [thread overview]
Message-ID: <20190107121224.6cdb1a9b.cohuck@redhat.com> (raw)
In-Reply-To: <20190104195714.30045-1-labbott@redhat.com>
On Fri, 4 Jan 2019 11:57:14 -0800
Laura Abbott <labbott@redhat.com> wrote:
> Commit 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2]
> subdriver") introduced a trace.h file in the local directory but
> missed adding the local include path, resulting in compilation
> failures with tracepoints:
>
> In file included from drivers/vfio/pci/trace.h:102,
> from drivers/vfio/pci/vfio_pci_nvlink2.c:29:
> ./include/trace/define_trace.h:89:42: fatal error: ./trace.h: No such file or directory
> #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
>
> Fix this by adjusting the include path.
>
> Fixes: 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] subdriver")
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> I'd still like to echo my sentiment that this should not be a def_bool.
> We hit this error on our internal testing and we couldn't even turn
> off the driver until we fixed this.
> ---
> drivers/vfio/pci/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vfio/pci/Makefile b/drivers/vfio/pci/Makefile
> index 9662c063a6b1..08d4676a8495 100644
> --- a/drivers/vfio/pci/Makefile
> +++ b/drivers/vfio/pci/Makefile
> @@ -1,3 +1,4 @@
> +ccflags-y += -I$(src)
>
> vfio-pci-y := vfio_pci.o vfio_pci_intrs.o vfio_pci_rdwr.o vfio_pci_config.o
> vfio-pci-$(CONFIG_VFIO_PCI_IGD) += vfio_pci_igd.o
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
prev parent reply other threads:[~2019-01-07 11:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 19:57 [PATCH] vfio_pci: Add local source directory as include Laura Abbott
2019-01-07 7:26 ` Alexey Kardashevskiy
2019-01-07 8:58 ` Michael Ellerman
2019-01-07 10:12 ` Masahiro Yamada
2019-01-07 11:07 ` Cornelia Huck
2019-01-07 11:39 ` Masahiro Yamada
2019-01-07 20:13 ` Alex Williamson
2019-01-07 23:52 ` Alexey Kardashevskiy
2019-01-08 0:24 ` Alex Williamson
2019-01-08 2:20 ` Alexey Kardashevskiy
2019-01-08 2:38 ` Masahiro Yamada
2019-01-08 2:57 ` Alexey Kardashevskiy
2019-01-08 3:19 ` Masahiro Yamada
2019-01-08 8:02 ` Michael Ellerman
2019-01-07 20:06 ` Laura Abbott
2019-01-07 11:12 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107121224.6cdb1a9b.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox