From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: + proc-fix-proc-net-after-setns2-checkpatch-fixes.patch added to -mm tree
Date: Mon, 7 Jan 2019 15:45:57 -0800 [thread overview]
Message-ID: <20190107154557.1f4bfeb8bf1aaa45a0d555e3@linux-foundation.org> (raw)
In-Reply-To: <20190107233720.GA26994@avx2>
On Tue, 8 Jan 2019 02:37:20 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Mon, Jan 07, 2019 at 02:36:09PM -0800, akpm@linux-foundation.org wrote:
> > Subject: proc-fix-proc-net-after-setns2-checkpatch-fixes
> >
> > WARNING: Block comments use * on subsequent lines
> > #56: FILE: fs/proc/proc_net.c:44:
> > + // /proc/net/* can be changed under us by setns(CLONE_NEWNET)
> > + pde->proc_dops = &simple_dentry_operations;
>
> I did it on purpose! Otherwise default vim colouring marks "/*" in red
> because it is comment without "*/"
There's always a way ;)
--- a/fs/proc/proc_net.c~proc-fix-proc-net-after-setns2-checkpatch-fixes-fix
+++ a/fs/proc/proc_net.c
@@ -40,7 +40,7 @@ static struct net *get_proc_net(const st
static void pde_force_lookup(struct proc_dir_entry *pde)
{
- /* /proc/net/* can be changed under us by setns(CLONE_NEWNET) */
+ /* /proc/net/ entries can be changed under us by setns(CLONE_NEWNET) */
pde->proc_dops = &simple_dentry_operations;
}
_
prev parent reply other threads:[~2019-01-07 23:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190107223609.Z6BC6rJ1M%akpm@linux-foundation.org>
2019-01-07 23:37 ` + proc-fix-proc-net-after-setns2-checkpatch-fixes.patch added to -mm tree Alexey Dobriyan
2019-01-07 23:45 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107154557.1f4bfeb8bf1aaa45a0d555e3@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox