From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Pi-Hsun Shih <pihsun@chromium.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
"open list:REMOTE PROCESSOR MESSAGING (RPMSG) SUBSYSTEM"
<linux-remoteproc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rpmsg: core: Make remove handler for rpmsg driver optional.
Date: Mon, 7 Jan 2019 09:30:03 -0800 [thread overview]
Message-ID: <20190107173003.GL31596@builder> (raw)
In-Reply-To: <20190107113833.243672-1-pihsun@chromium.org>
On Mon 07 Jan 03:38 PST 2019, Pi-Hsun Shih wrote:
> Most other bus (for example, SPI, i2c) have the remove handler for
> driver optional. Make remove handler for rpmsg driver optional too.
>
> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
Thanks Pi-Hsun, applied.
Regards,
Bjorn
> ---
> drivers/rpmsg/rpmsg_core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
> index 8122807db38094..ea88fd4e2a6ecf 100644
> --- a/drivers/rpmsg/rpmsg_core.c
> +++ b/drivers/rpmsg/rpmsg_core.c
> @@ -493,7 +493,8 @@ static int rpmsg_dev_remove(struct device *dev)
> if (rpdev->ops->announce_destroy)
> err = rpdev->ops->announce_destroy(rpdev);
>
> - rpdrv->remove(rpdev);
> + if (rpdrv->remove)
> + rpdrv->remove(rpdev);
>
> dev_pm_domain_detach(dev, true);
>
> --
> 2.20.1.97.g81188d93c3-goog
>
prev parent reply other threads:[~2019-01-07 17:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 11:38 [PATCH] rpmsg: core: Make remove handler for rpmsg driver optional Pi-Hsun Shih
2019-01-07 17:30 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190107173003.GL31596@builder \
--to=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=pihsun@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox