* [PATCH] md-linear: use struct_size() in kzalloc()
@ 2019-01-07 17:45 Gustavo A. R. Silva
2019-01-07 23:01 ` Song Liu
0 siblings, 1 reply; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-07 17:45 UTC (permalink / raw)
To: Shaohua Li; +Cc: linux-raid, linux-kernel, Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:
struct foo {
int stuff;
void *entry[];
};
instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:
instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/md/md-linear.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c
index d45c697c0ebe..5998d78aa189 100644
--- a/drivers/md/md-linear.c
+++ b/drivers/md/md-linear.c
@@ -96,8 +96,7 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
int i, cnt;
bool discard_supported = false;
- conf = kzalloc (sizeof (*conf) + raid_disks*sizeof(struct dev_info),
- GFP_KERNEL);
+ conf = kzalloc(struct_size(conf, disks, raid_disks), GFP_KERNEL);
if (!conf)
return NULL;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] md-linear: use struct_size() in kzalloc()
2019-01-07 17:45 [PATCH] md-linear: use struct_size() in kzalloc() Gustavo A. R. Silva
@ 2019-01-07 23:01 ` Song Liu
2019-01-29 17:22 ` Gustavo A. R. Silva
0 siblings, 1 reply; 5+ messages in thread
From: Song Liu @ 2019-01-07 23:01 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Shaohua Li, linux-raid, open list
On Mon, Jan 7, 2019 at 10:35 AM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
> One of the more common cases of allocation size calculations is finding the
> size of a structure that has a zero-sized array at the end, along with memory
> for some number of elements for that array. For example:
>
> struct foo {
> int stuff;
> void *entry[];
> };
>
> instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
>
> Instead of leaving these open-coded and prone to type mistakes, we can now
> use the new struct_size() helper:
>
> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Song Liu <songliubraving@fb.com>
> ---
> drivers/md/md-linear.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c
> index d45c697c0ebe..5998d78aa189 100644
> --- a/drivers/md/md-linear.c
> +++ b/drivers/md/md-linear.c
> @@ -96,8 +96,7 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
> int i, cnt;
> bool discard_supported = false;
>
> - conf = kzalloc (sizeof (*conf) + raid_disks*sizeof(struct dev_info),
> - GFP_KERNEL);
> + conf = kzalloc(struct_size(conf, disks, raid_disks), GFP_KERNEL);
> if (!conf)
> return NULL;
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] md-linear: use struct_size() in kzalloc()
2019-01-07 23:01 ` Song Liu
@ 2019-01-29 17:22 ` Gustavo A. R. Silva
2019-01-29 22:10 ` Song Liu
0 siblings, 1 reply; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-01-29 17:22 UTC (permalink / raw)
To: Song Liu; +Cc: Shaohua Li, linux-raid, open list
Hi all,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
On 1/7/19 5:01 PM, Song Liu wrote:
> On Mon, Jan 7, 2019 at 10:35 AM Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>>
>> One of the more common cases of allocation size calculations is finding the
>> size of a structure that has a zero-sized array at the end, along with memory
>> for some number of elements for that array. For example:
>>
>> struct foo {
>> int stuff;
>> void *entry[];
>> };
>>
>> instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
>>
>> Instead of leaving these open-coded and prone to type mistakes, we can now
>> use the new struct_size() helper:
>>
>> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Acked-by: Song Liu <songliubraving@fb.com>
>
>> ---
>> drivers/md/md-linear.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c
>> index d45c697c0ebe..5998d78aa189 100644
>> --- a/drivers/md/md-linear.c
>> +++ b/drivers/md/md-linear.c
>> @@ -96,8 +96,7 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
>> int i, cnt;
>> bool discard_supported = false;
>>
>> - conf = kzalloc (sizeof (*conf) + raid_disks*sizeof(struct dev_info),
>> - GFP_KERNEL);
>> + conf = kzalloc(struct_size(conf, disks, raid_disks), GFP_KERNEL);
>> if (!conf)
>> return NULL;
>>
>> --
>> 2.20.1
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] md-linear: use struct_size() in kzalloc()
2019-01-29 17:22 ` Gustavo A. R. Silva
@ 2019-01-29 22:10 ` Song Liu
2019-01-29 22:18 ` Gustavo A. R. Silva
0 siblings, 1 reply; 5+ messages in thread
From: Song Liu @ 2019-01-29 22:10 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Shaohua Li, linux-raid, open list
I will take it, and send pull request.
Thanks,
Song
On Tue, Jan 29, 2019 at 9:22 AM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
> Hi all,
>
> Friendly ping:
>
> Who can take this?
>
> Thanks
> --
> Gustavo
>
> On 1/7/19 5:01 PM, Song Liu wrote:
> > On Mon, Jan 7, 2019 at 10:35 AM Gustavo A. R. Silva
> > <gustavo@embeddedor.com> wrote:
> >>
> >> One of the more common cases of allocation size calculations is finding the
> >> size of a structure that has a zero-sized array at the end, along with memory
> >> for some number of elements for that array. For example:
> >>
> >> struct foo {
> >> int stuff;
> >> void *entry[];
> >> };
> >>
> >> instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
> >>
> >> Instead of leaving these open-coded and prone to type mistakes, we can now
> >> use the new struct_size() helper:
> >>
> >> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
> >>
> >> This code was detected with the help of Coccinelle.
> >>
> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> >
> > Acked-by: Song Liu <songliubraving@fb.com>
> >
> >> ---
> >> drivers/md/md-linear.c | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c
> >> index d45c697c0ebe..5998d78aa189 100644
> >> --- a/drivers/md/md-linear.c
> >> +++ b/drivers/md/md-linear.c
> >> @@ -96,8 +96,7 @@ static struct linear_conf *linear_conf(struct mddev *mddev, int raid_disks)
> >> int i, cnt;
> >> bool discard_supported = false;
> >>
> >> - conf = kzalloc (sizeof (*conf) + raid_disks*sizeof(struct dev_info),
> >> - GFP_KERNEL);
> >> + conf = kzalloc(struct_size(conf, disks, raid_disks), GFP_KERNEL);
> >> if (!conf)
> >> return NULL;
> >>
> >> --
> >> 2.20.1
> >>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-29 22:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-07 17:45 [PATCH] md-linear: use struct_size() in kzalloc() Gustavo A. R. Silva
2019-01-07 23:01 ` Song Liu
2019-01-29 17:22 ` Gustavo A. R. Silva
2019-01-29 22:10 ` Song Liu
2019-01-29 22:18 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox