Re: + proc-fix-proc-net-after-setns2-checkpatch-fixes.patch added to -mm tree

Andrew Morton
2019-01-07T23:46:00Z

On Tue, 8 Jan 2019 02:37:20 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Mon, Jan 07, 2019 at 02:36:09PM -0800, akpm@linux-foundation.org wrote:
> > Subject: proc-fix-proc-net-after-setns2-checkpatch-fixes
> >
> > WARNING: Block comments use * on subsequent lines
> > #56: FILE: fs/proc/proc_net.c:44:
> > + // /proc/net/* can be changed under us by setns(CLONE_NEWNET)
> > + pde->proc_dops = &simple_dentry_operations;
>
> I did it on purpose! Otherwise default vim colouring marks "/*" in red
> because it is comment without "*/"

There's always a way ;)

--- a/fs/proc/proc_net.c~proc-fix-proc-net-after-setns2-checkpatch-fixes-fix
+++ a/fs/proc/proc_net.c
@@ -40,7 +40,7 @@ static struct net *get_proc_net(const st

static void pde_force_lookup(struct proc_dir_entry *pde)
{
- /* /proc/net/* can be changed under us by setns(CLONE_NEWNET) */
+ /* /proc/net/ entries can be changed under us by setns(CLONE_NEWNET) */
pde->proc_dops = &simple_dentry_operations;
}

_