From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ran Wang <ran.wang_1@nxp.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms
Date: Tue, 8 Jan 2019 16:45:23 +0100 [thread overview]
Message-ID: <20190108154523.GB20989@kroah.com> (raw)
In-Reply-To: <20190108060426.11581-2-ran.wang_1@nxp.com>
On Tue, Jan 08, 2019 at 06:04:26AM +0000, Ran Wang wrote:
> arm/arm64's io.h doesn't define clrbits32() and clrsetbits_be32(), which
> causing compile failure on some Layerscape Platforms (such as LS1021A and
> LS2012A which also integrates FSL EHCI controller). So use
> ioread32be()/iowrite32be() instead to make it workable on both
> powerpc and arm.
Shouldn't you have this patch before the Kconfig change, so that you do
not break the build on ARM systems on that one and then fix it up on
this one?
thanks,
greg k-h
next prev parent reply other threads:[~2019-01-08 15:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 6:04 [PATCH 1/3] usb: kconfig: remove dependency FSL_SOC for ehci fsl driver Ran Wang
2019-01-08 6:04 ` [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms Ran Wang
2019-01-08 15:45 ` Greg Kroah-Hartman [this message]
2019-01-17 8:06 ` Ran Wang
2019-01-08 16:20 ` Alan Stern
2019-01-09 3:37 ` Ran Wang
2019-01-09 15:14 ` Alan Stern
2019-01-10 3:41 ` Ran Wang
2019-01-10 15:29 ` Alan Stern
2019-01-11 9:10 ` Ran Wang
2019-01-08 6:04 ` [PATCH 3/3] drivers: usb :fsl: Remove USB Errata checking code Ran Wang
2019-01-08 15:44 ` Greg Kroah-Hartman
2019-01-09 2:35 ` Ran Wang
2019-01-08 16:22 ` Alan Stern
2019-01-09 3:52 ` Ran Wang
2019-01-08 16:59 ` kbuild test robot
2019-01-08 16:11 ` [PATCH 1/3] usb: kconfig: remove dependency FSL_SOC for ehci fsl driver Alan Stern
2019-01-09 3:23 ` Ran Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108154523.GB20989@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ran.wang_1@nxp.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox