From: Mel Gorman <mgorman@techsingularity.net>
To: Mike Galbraith <efault@gmx.de>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] RFC: sched/fair: skip select_idle_sibling() in presence of sync wakeups
Date: Wed, 9 Jan 2019 10:07:51 +0000 [thread overview]
Message-ID: <20190109100751.GQ31517@techsingularity.net> (raw)
In-Reply-To: <1547007588.17100.17.camel@gmx.de>
On Wed, Jan 09, 2019 at 05:19:48AM +0100, Mike Galbraith wrote:
> > To test I used this trivial program.
>
> Which highlights the problem. That proggy really is synchronous, but
> the sync hint is applied to many MANY real world cases where this is
> not the case at all. Sure, you can make things like pipe_test and
> nearly nonexistent payload TCP_RR numbers look gorgeous, but that
> demolishes concurrency for real applications.
>
I agree with Mike here. Many previous attempts to strictly obey the strict
hint has led to regressions elsewhere -- specifically a task waking 2+
wakees that temporarily stack on one CPU when nearby CPUs sharing LLC
remain idle. It's why the select idle sibling logic tried to take into
account a recently used CPU to wake such tasks if the recent CPU was
still idle.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2019-01-09 10:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 3:49 [PATCH 0/1] RFC: sched/fair: skip select_idle_sibling() in presence of sync wakeups Andrea Arcangeli
2019-01-09 3:49 ` [PATCH 1/1] " Andrea Arcangeli
2019-01-09 4:19 ` [PATCH 0/1] RFC: " Mike Galbraith
2019-01-09 10:07 ` Mel Gorman [this message]
2019-01-09 18:24 ` Andrea Arcangeli
2019-01-09 18:02 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109100751.GQ31517@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=aarcange@redhat.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).