Re: [PATCH v2 0/6] General Key Derivation Function Support

Herbert Xu
2019-01-30T10:09:52Z

On Mon, Jan 28, 2019 at 11:07:28AM +0100, Stephan Mueller wrote:
> Am Mittwoch, 16. Januar 2019, 12:06:54 CET schrieb Stephan Müller:
>
> Hi Herbert,
>
> > Changes v2:
> > * Incorporation of all comments from Eric Biggers
> >
> > Stephan Mueller (6):
> > crypto: add template handling for RNGs
> > crypto: kdf - SP800-108 Key Derivation Function
> > crypto: kdf - add known answer tests
> > crypto: hkdf - HMAC-based Extract-and-Expand KDF
> > crypto: hkdf - add known answer tests
> > crypto: tcrypt - add KDF test invocation
> >
> > crypto/Kconfig | 13 +
> > crypto/Makefile | 2 +
> > crypto/hkdf.c | 272 +++++++++++++++++++
> > crypto/kdf_sp800108.c | 491 ++++++++++++++++++++++++++++++++++
> > crypto/rng.c | 44 +++
> > crypto/tcrypt.c | 8 +
> > crypto/testmgr.c | 245 +++++++++++++++++
> > crypto/testmgr.h | 198 ++++++++++++++
> > include/crypto/internal/rng.h | 26 ++
> > 9 files changed, 1299 insertions(+)
> > create mode 100644 crypto/hkdf.c
> > create mode 100644 crypto/kdf_sp800108.c
>
> Do you happen to have any comments on this patch set?

I'm still not convinced why this needs to go into the crypto API
instead of being hosted in a helper which should achieve pretty
much the same result.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt