From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D3EC43444 for ; Wed, 9 Jan 2019 17:22:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 696D9206B7 for ; Wed, 9 Jan 2019 17:22:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547054531; bh=x59Z4BaZlWUuL8ZjCtMQUTLKgd25tvlyk9JJkaGK9vo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=stzSfbFNn0DymdMkZDhLb0Ywzc76aBxJ5iLKkRDetxGb2uG1Ng6NQfS7K5dkeYg6c g3oWEJ67wlKW1bKO/fPqOGnVgUrhKCfGn9nvehjBXqusIIepT5nu6W+PtpLcixqyJn FNXUF/mjrDJw57dvfwi8TmrrsGU8HfJI2BqM2wlo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726894AbfAIRWK (ORCPT ); Wed, 9 Jan 2019 12:22:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:57546 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726574AbfAIRWK (ORCPT ); Wed, 9 Jan 2019 12:22:10 -0500 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2FDDC20660; Wed, 9 Jan 2019 17:22:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547054529; bh=x59Z4BaZlWUuL8ZjCtMQUTLKgd25tvlyk9JJkaGK9vo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tNpXLBGGzhW8WA1SFmmuo/Y9jMCLorRZLSJUgtq2E1wopZyTWamEsZJvHdnFvQBYh AqulMYNj90GnfpadUfF44PUlsy3lzYehOSHI8gDaHYstqv2jRX8TDrlqb06CTH5YSN 87+vmH41fmr+enu1tUySHC2yGo/1phsJUFYAJZPA= Date: Wed, 9 Jan 2019 09:22:07 -0800 From: Eric Biggers To: Kalyani Akula Cc: herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Kalyani Akula , Sarat Chand Savitala Subject: Re: [RFC PATCH 2/3] crypto: Add Xilinx SHA3 driver Message-ID: <20190109172206.GA249140@gmail.com> References: <1546851776-3456-1-git-send-email-kalyani.akula@xilinx.com> <1546851776-3456-3-git-send-email-kalyani.akula@xilinx.com> <20190107165606.GA2077@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190107165606.GA2077@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 07, 2019 at 08:56:07AM -0800, Eric Biggers wrote: > Hi Kalyani, > > On Mon, Jan 07, 2019 at 02:32:55PM +0530, Kalyani Akula wrote: > > This patch adds SHA3 driver suuport for the Xilinx > > ZynqMP SoC. > > > > Signed-off-by: Kalyani Akula > [...] > > + > > +static struct ahash_alg sha3_alg = { > > + .init = zynqmp_sha_init, > > + .update = zynqmp_sha_update, > > + .final = zynqmp_sha_final, > > + .finup = zynqmp_sha_finup, > > + .digest = zynqmp_sha_digest, > > + .export = zynqmp_sha_export, > > + .import = zynqmp_sha_import, > > + .halg = { > > + .digestsize = SHA384_DIGEST_SIZE, > > + .statesize = sizeof(struct sha256_state), > > + .base = { > > + .cra_name = "xilinx-keccak-384", > > + .cra_driver_name = "zynqmp-keccak-384", > > + .cra_priority = 300, > > + .cra_flags = CRYPTO_ALG_ASYNC, > > + .cra_blocksize = SHA384_BLOCK_SIZE, > > + .cra_ctxsize = sizeof(struct zynqmp_sha_ctx), > > + .cra_alignmask = 0, > > + .cra_module = THIS_MODULE, > > + .cra_init = zynqmp_sha_cra_init, > > + } > > + } > > +}; > > cra_name needs to match an algorithm that has a generic implementation. > It should be "sha3-384", or is your hardware not compatible? > Also does your hardware not support sha3-256 and sha3-512? > > - Eric Hi Kalyani, this was not addressed in v2. - Eric