From: Mark Brown <broonie@kernel.org>
To: b-ak <anur.bhargav@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: tlv320aic32x4: SND_SOC_DAPM_MICBIAS is deprecated
Date: Wed, 9 Jan 2019 18:38:36 +0000 [thread overview]
Message-ID: <20190109183836.GI10405@sirena.org.uk> (raw)
In-Reply-To: <20190109171121.GA12810@Ideapad-330S>
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
On Wed, Jan 09, 2019 at 10:41:21PM +0530, b-ak wrote:
> SND_SOC_DAPM_MICBIAS is deprecated, replace it with SND_SOC_DAPM_SUPPLY.
>
> MICBIAS voltage wasn't supplied to the microphone with the older
> SND_SOC_DAPM_MICBIAS widget, hence the microphone wouldn't work.
>
> This patch fixes the problem.
Note that the reason we've not done that already for everything is that
the DAPM graph needs updating for the new routing in machine drivers as
the two widgets are wired differently. However this is fine here as
there aren't any in tree users I can see so I'll apply, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-09 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 17:11 [PATCH] ASoC: tlv320aic32x4: SND_SOC_DAPM_MICBIAS is deprecated b-ak
2019-01-09 18:38 ` Mark Brown [this message]
2019-01-09 18:51 ` b-ak
2019-01-09 19:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109183836.GI10405@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=anur.bhargav@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox