From: Logan Gunthorpe <logang@deltatee.com>
To: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com,
Jon Mason <jdmason@kudzu.us>
Cc: Allen Hubbe <allenbh@gmail.com>,
Dave Jiang <dave.jiang@intel.com>,
Serge Semin <fancer.lancer@gmail.com>,
Logan Gunthorpe <logang@deltatee.com>
Subject: [PATCH v3 0/8] Fix breakage caused by the NTB multi-port patchset
Date: Wed, 9 Jan 2019 12:22:25 -0700 [thread overview]
Message-ID: <20190109192233.5752-1-logang@deltatee.com> (raw)
Hey,
I'm resending this because I've recently found out that the change we
made to use the NTB struct device in DMA allocations is wrong and
needs to be reverted. Turns out that, when running with an IOMMU,
dma_alloc_coherent() will always fail if you pass it the NTB struct
device. This is because the device has not been assigned an IOMMU
group and the Intel IOMMU at least expect the devices to be on the PCI
bus and be able to find a proper bus-dev-fn number through a struct
pci device. Therefore, we must revert the change and I've changed
patch 2 to do this and remove the no longer necessary DMA mask
adjustments.
I'm not sure if we can get past the impass in getting this series merged:
I still maintain every patch in this series is necessary to fix a
regression and there's no way to add port numbers to switchtec in the
crosslink configuration so it can't be fixed in the other way that was
suggested.
Logan
--
Changes since v2:
- Rebased on v5.0-rc1
- Modify Patch 2 to revert back to using the PCI struct device
instead of the NTB struct device in DMA calls
- Collected Allen's Acks
- Collected Alexander's Tested-By
Changes since v1:
- Rebased onto ntb-next (there was a minor conflict in a recent change
to the intel driver)
- Collected Dave's Ack
--
Logan Gunthorpe (8):
NTB: ntb_tool: reading the link file should not end in a NULL byte
NTB: Revert the change to use the NTB device dev for DMA allocations
NTB: Fix the default port and peer numbers for legacy drivers
NTB: ntb_pingpong: Choose doorbells based on port number
NTB: perf: Don't require one more memory window than number of peers
NTB: perf: Fix support for hardware that doesn't have port numbers
NTB: perf: Fix race condition when run with ntb_test
NTB: ntb_test: Fix bug when counting remote files
drivers/ntb/hw/amd/ntb_hw_amd.c | 4 ----
drivers/ntb/hw/idt/ntb_hw_idt.c | 6 -----
drivers/ntb/hw/intel/ntb_hw_gen1.c | 4 ----
drivers/ntb/ntb.c | 9 ++------
drivers/ntb/test/ntb_perf.c | 29 +++++++++++++++++++------
drivers/ntb/test/ntb_pingpong.c | 14 +++++-------
drivers/ntb/test/ntb_tool.c | 9 ++++----
tools/testing/selftests/ntb/ntb_test.sh | 2 +-
8 files changed, 35 insertions(+), 42 deletions(-)
--
2.19.0
next reply other threads:[~2019-01-09 19:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 19:22 Logan Gunthorpe [this message]
2019-01-09 19:22 ` [PATCH v3 1/8] NTB: ntb_tool: reading the link file should not end in a NULL byte Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 2/8] NTB: Revert the change to use the NTB device dev for DMA allocations Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 3/8] NTB: Fix the default port and peer numbers for legacy drivers Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 4/8] NTB: ntb_pingpong: Choose doorbells based on port number Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 5/8] NTB: perf: Don't require one more memory window than number of peers Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 6/8] NTB: perf: Fix support for hardware that doesn't have port numbers Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 7/8] NTB: perf: Fix race condition when run with ntb_test Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 8/8] NTB: ntb_test: Fix bug when counting remote files Logan Gunthorpe
2019-01-09 19:32 ` [PATCH v3 0/8] Fix breakage caused by the NTB multi-port patchset Dave Jiang
2019-01-09 19:33 ` Logan Gunthorpe
2019-02-11 14:40 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109192233.5752-1-logang@deltatee.com \
--to=logang@deltatee.com \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox