From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sidong Yang <realwakka@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vboxvideo: vbox_main: Remove unnecessary local variable
Date: Thu, 10 Jan 2019 15:23:58 +0300 [thread overview]
Message-ID: <20190110122358.GC1743@kadam> (raw)
In-Reply-To: <20190110061347.31326-1-realwakka@gmail.com>
On Thu, Jan 10, 2019 at 06:13:47AM +0000, Sidong Yang wrote:
> Removed unnecessary local variable in have_hgsmi_mode_hints.
> The result of hgsmi_query_conf should be directly compared without
> assigning to local variable.
>
> Signed-off-by: Sidong Yang <realwakka@gmail.com>
> ---
I sort of prefer the original...
The hgsmi_query_conf() function returns negative error codes if it
can't complete the query because of allocation failures. To me that's
more obvious, when we write it in the original way.
In the new code it looks like it returns bool or something. The
copy_to/from_user() are normally written like if (copy_to_user()) {
but those don't return negative error codes so it's a different
situation.
This isn't something in checkpatch or CodingStyle so there isn't a
standard. It's just personal opinion vs personal opinion. If you were
going to do a lot of vboxvideo development, then it would be your
opinion which matters the most because you are doing the work. But
this is your first vboxvideo patch...
Let's just leave it as-is.
regards,
dan carpenter
next prev parent reply other threads:[~2019-01-10 12:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 6:13 [PATCH] staging: vboxvideo: vbox_main: Remove unnecessary local variable Sidong Yang
2019-01-10 12:23 ` Dan Carpenter [this message]
2019-01-10 17:00 ` Sidong Yang
2019-01-10 19:44 ` Dan Carpenter
2019-01-11 3:36 ` Sidong Yang
2019-01-11 9:42 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110122358.GC1743@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=realwakka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox