From: Keith Busch <keith.busch@intel.com>
To: Yao HongBo <yaohongbo@huawei.com>
Cc: Christoph Hellwig <hch@lst.de>,
"wangxiongfeng2@huawei.com" <wangxiongfeng2@huawei.com>,
"guohanjun@huawei.com" <guohanjun@huawei.com>,
"huawei.libin@huawei.com" <huawei.libin@huawei.com>,
"thunder.leizhen@huawei.com" <thunder.leizhen@huawei.com>,
"tanxiaojun@huawei.com" <tanxiaojun@huawei.com>,
"xiexiuqi@huawei.com" <xiexiuqi@huawei.com>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"cj.chengjian@huawei.com" <cj.chengjian@huawei.com>,
"wxf.wang@hisilicon.com" <wxf.wang@hisilicon.com>,
"axboe@fb.com" <axboe@fb.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: fix out of bounds access in nvme_cqe_pending
Date: Thu, 10 Jan 2019 07:50:08 -0700 [thread overview]
Message-ID: <20190110145008.GA21095@localhost.localdomain> (raw)
In-Reply-To: <991b5090-adf7-78e1-ae19-0df94566c212@huawei.com>
On Wed, Jan 09, 2019 at 05:54:59PM -0800, Yao HongBo wrote:
> On 1/10/2019 2:39 AM, Christoph Hellwig wrote:
> > On Mon, Jan 07, 2019 at 10:22:07AM +0800, Hongbo Yao wrote:
> >> There is an out of bounds array access in nvme_cqe_peding().
> >>
> >> When enable irq_thread for nvme interrupt, there is racing between the
> >> nvmeq->cq_head updating and reading.
> >
> > Just curious: why did you enable this option? Do you have a workload
> > where it matters?
>
> Yes, there were a lot of hard interrupts reported when reading the nvme disk,
> the OS can not schedule and result in the soft lockup.so i enabled the irq_thread.
That seems a little unusual. We should be able to handle as many
interrupts as an nvme drive can send.
prev parent reply other threads:[~2019-01-10 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 2:22 [PATCH] nvme: fix out of bounds access in nvme_cqe_pending Hongbo Yao
2019-01-09 18:39 ` Christoph Hellwig
2019-01-10 1:54 ` Yao HongBo
2019-01-10 14:50 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110145008.GA21095@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=cj.chengjian@huawei.com \
--cc=guohanjun@huawei.com \
--cc=hch@lst.de \
--cc=huawei.libin@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=tanxiaojun@huawei.com \
--cc=thunder.leizhen@huawei.com \
--cc=wangxiongfeng2@huawei.com \
--cc=wxf.wang@hisilicon.com \
--cc=xiexiuqi@huawei.com \
--cc=yangyingliang@huawei.com \
--cc=yaohongbo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox