From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AD1BC43387 for ; Fri, 11 Jan 2019 14:45:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4298F206B6 for ; Fri, 11 Jan 2019 14:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547217954; bh=puPGQPLEik0vGkEMzObkoARi8pGHcRNv7h67RElq5XE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=I8cKpCFhHRzSG39tEsaaTLM7WqPWlDzDXc2HKfFGOKEz60BHVY9XEYjsXxpvF+hkG gkNTmfNhAb92KWqCClxlaV6fikxbRgtw3YGyVbdtfPR4D87EXe9eiWCPuNwGe61qOX qsf6tF1x9yMALIp9oCm/jqSCmTm7Kgm5WsLzE7/4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391438AbfAKOpx (ORCPT ); Fri, 11 Jan 2019 09:45:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:36550 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404421AbfAKOni (ORCPT ); Fri, 11 Jan 2019 09:43:38 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6072920872; Fri, 11 Jan 2019 14:43:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547217817; bh=puPGQPLEik0vGkEMzObkoARi8pGHcRNv7h67RElq5XE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FjuXQBLuMWtdvhlTdbOJmLz3UTHT1q1g3fwHN5U/X+uYZ9bKlXKklqEy1b28iw0yy RldhBoo7JCz4vHyD6NGtQ6f4zZA5qxGaVIfra3csZSi6w9xikCToS+VyKavvd6zm11 prXBQvz4hGW2WSkHZ0r7AJfTbMV2F8Tvy/QuWhrg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Yan, Zheng" , Ilya Dryomov Subject: [PATCH 4.20 52/65] ceph: dont update importing caps mseq when handing cap export Date: Fri, 11 Jan 2019 15:15:38 +0100 Message-Id: <20190111131103.289816814@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190111131055.331350141@linuxfoundation.org> References: <20190111131055.331350141@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yan, Zheng commit 3c1392d4c49962a31874af14ae9ff289cb2b3851 upstream. Updating mseq makes client think importer mds has accepted all prior cap messages and importer mds knows what caps client wants. Actually some cap messages may have been dropped because of mseq mismatch. If mseq is left untouched, importing cap's mds_wanted later will get reset by cap import message. Cc: stable@vger.kernel.org Signed-off-by: "Yan, Zheng" Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- fs/ceph/caps.c | 1 - 1 file changed, 1 deletion(-) --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c @@ -3569,7 +3569,6 @@ retry: tcap->cap_id = t_cap_id; tcap->seq = t_seq - 1; tcap->issue_seq = t_seq - 1; - tcap->mseq = t_mseq; tcap->issued |= issued; tcap->implemented |= issued; if (cap == ci->i_auth_cap)