Re: [PATCH v3 12/12] drm: remove drmP.h from drm_gem_cma_helper.h

Daniel Vetter
2019-01-09T22:24:12Z

On Tue, Jan 08, 2019 at 08:29:39PM +0100, Sam Ravnborg wrote:
> With all dependencies fixed we can now remove
> drmP.h from drm_gem_cma_helper.h.
> It is replaced by the include files required,
> or forward declarations as appropritate.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Acked-by: Noralf Trønnes <noralf@tronnes.org>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>

Except for the ones I commented on, all patches applied. I also fixed the
one typo in the summary.

Thanks, Daniel
> ---
> include/drm/drm_gem_cma_helper.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_gem_cma_helper.h b/include/drm/drm_gem_cma_helper.h
> index 07c504940ba1..947ac95eb24a 100644
> --- a/include/drm/drm_gem_cma_helper.h
> +++ b/include/drm/drm_gem_cma_helper.h
> @@ -2,9 +2,12 @@
> #ifndef __DRM_GEM_CMA_HELPER_H__
> #define __DRM_GEM_CMA_HELPER_H__
>
> -#include <drm/drmP.h>
> +#include <drm/drm_file.h>
> +#include <drm/drm_ioctl.h>
> #include <drm/drm_gem.h>
>
> +struct drm_mode_create_dumb;
> +
> /**
> * struct drm_gem_cma_object - GEM object backed by CMA memory allocations
> * @base: base GEM object
> --
> 2.12.0
>

--
Daniel Vetter
Software Engineer, Intel Corporation