From: Aurelien Jarno <aurelien@aurel32.net>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, x86@kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
"H . J . Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1
Date: Sat, 12 Jan 2019 20:07:13 +0100 [thread overview]
Message-ID: <20190112190713.GA21480@aurel32.net> (raw)
In-Reply-To: <20181206190534.16246-1-aurelien@aurel32.net>
On 2018-12-06 20:05, Aurelien Jarno wrote:
> The preadv2 and pwritev2 syscalls are supposed to emulate the readv and
> writev syscalls when offset == -1. Therefore the compat code should
> check for offset before calling do_compat_preadv64 and
> do_compat_pwritev64. This is the case for the preadv2 and pwritev2
> syscalls, but handling of offset == -1 is missing in their 64-bit
> equivalent.
>
> This patch fixes that, calling do_compat_readv and do_compat_writev when
> offset == -1. This fixes the following glibc tests on x32:
> - misc/tst-preadvwritev2
> - misc/tst-preadvwritev64v2
>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: H.J. Lu <hjl.tools@gmail.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> fs/read_write.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Any news about this patch?
Thanks,
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2019-01-12 19:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 19:05 [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1 Aurelien Jarno
2019-01-12 19:07 ` Aurelien Jarno [this message]
2019-02-16 15:15 ` Aurelien Jarno
2019-02-16 15:21 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190112190713.GA21480@aurel32.net \
--to=aurelien@aurel32.net \
--cc=hjl.tools@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox