* [PATCH] pinctrl: cherryview: fix Strago DMI workaround
@ 2019-01-15 3:38 Dmitry Torokhov
2019-01-15 5:32 ` Andy Shevchenko
2019-01-21 12:06 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2019-01-15 3:38 UTC (permalink / raw)
To: Mika Westerberg
Cc: Andy Shevchenko, Linus Walleij, Guenter Roeck, linux-gpio,
linux-kernel
Well, hopefully 3rd time is a charm. We tried making that check
DMI_BIOS_VERSION and DMI_BOARD_VERSION, but the real one is
DMI_PRODUCT_VERSION.
Fixes: 86c5dd6860a6 ("pinctrl: cherryview: limit Strago DMI workarounds to version 1.0")
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1631930
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/pinctrl/intel/pinctrl-cherryview.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
index 9b0f4b9ef482..8efe8ea45602 100644
--- a/drivers/pinctrl/intel/pinctrl-cherryview.c
+++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
@@ -1507,7 +1507,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"),
- DMI_MATCH(DMI_BOARD_VERSION, "1.0"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
},
},
{
@@ -1515,7 +1515,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "HP"),
DMI_MATCH(DMI_PRODUCT_NAME, "Setzer"),
- DMI_MATCH(DMI_BOARD_VERSION, "1.0"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
},
},
{
@@ -1523,7 +1523,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"),
- DMI_MATCH(DMI_BOARD_VERSION, "1.0"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
},
},
{
@@ -1531,7 +1531,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
- DMI_MATCH(DMI_BOARD_VERSION, "1.0"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
},
},
{}
--
2.20.1.97.g81188d93c3-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: cherryview: fix Strago DMI workaround
2019-01-15 3:38 [PATCH] pinctrl: cherryview: fix Strago DMI workaround Dmitry Torokhov
@ 2019-01-15 5:32 ` Andy Shevchenko
2019-01-21 11:12 ` Mika Westerberg
2019-01-21 12:06 ` Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2019-01-15 5:32 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Mika Westerberg, Linus Walleij, Guenter Roeck, linux-gpio,
linux-kernel
On Mon, Jan 14, 2019 at 07:38:36PM -0800, Dmitry Torokhov wrote:
> Well, hopefully 3rd time is a charm. We tried making that check
> DMI_BIOS_VERSION and DMI_BOARD_VERSION, but the real one is
> DMI_PRODUCT_VERSION.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Fixes: 86c5dd6860a6 ("pinctrl: cherryview: limit Strago DMI workarounds to version 1.0")
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1631930
> Cc: stable@vger.kernel.org
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/pinctrl/intel/pinctrl-cherryview.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
> index 9b0f4b9ef482..8efe8ea45602 100644
> --- a/drivers/pinctrl/intel/pinctrl-cherryview.c
> +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
> @@ -1507,7 +1507,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
> DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"),
> - DMI_MATCH(DMI_BOARD_VERSION, "1.0"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
> },
> },
> {
> @@ -1515,7 +1515,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "HP"),
> DMI_MATCH(DMI_PRODUCT_NAME, "Setzer"),
> - DMI_MATCH(DMI_BOARD_VERSION, "1.0"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
> },
> },
> {
> @@ -1523,7 +1523,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
> DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"),
> - DMI_MATCH(DMI_BOARD_VERSION, "1.0"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
> },
> },
> {
> @@ -1531,7 +1531,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
> DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
> - DMI_MATCH(DMI_BOARD_VERSION, "1.0"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "1.0"),
> },
> },
> {}
> --
> 2.20.1.97.g81188d93c3-goog
>
>
> --
> Dmitry
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: cherryview: fix Strago DMI workaround
2019-01-15 5:32 ` Andy Shevchenko
@ 2019-01-21 11:12 ` Mika Westerberg
0 siblings, 0 replies; 4+ messages in thread
From: Mika Westerberg @ 2019-01-21 11:12 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Dmitry Torokhov, Linus Walleij, Guenter Roeck, linux-gpio,
linux-kernel
On Tue, Jan 15, 2019 at 07:32:58AM +0200, Andy Shevchenko wrote:
> On Mon, Jan 14, 2019 at 07:38:36PM -0800, Dmitry Torokhov wrote:
> > Well, hopefully 3rd time is a charm. We tried making that check
> > DMI_BIOS_VERSION and DMI_BOARD_VERSION, but the real one is
> > DMI_PRODUCT_VERSION.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Also,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pinctrl: cherryview: fix Strago DMI workaround
2019-01-15 3:38 [PATCH] pinctrl: cherryview: fix Strago DMI workaround Dmitry Torokhov
2019-01-15 5:32 ` Andy Shevchenko
@ 2019-01-21 12:06 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2019-01-21 12:06 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Mika Westerberg, Andy Shevchenko, Guenter Roeck,
open list:GPIO SUBSYSTEM, linux-kernel@vger.kernel.org
On Tue, Jan 15, 2019 at 4:38 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> Well, hopefully 3rd time is a charm. We tried making that check
> DMI_BIOS_VERSION and DMI_BOARD_VERSION, but the real one is
> DMI_PRODUCT_VERSION.
>
> Fixes: 86c5dd6860a6 ("pinctrl: cherryview: limit Strago DMI workarounds to version 1.0")
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1631930
> Cc: stable@vger.kernel.org
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Patch applied for fixes with the ACKs!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-21 12:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-15 3:38 [PATCH] pinctrl: cherryview: fix Strago DMI workaround Dmitry Torokhov
2019-01-15 5:32 ` Andy Shevchenko
2019-01-21 11:12 ` Mika Westerberg
2019-01-21 12:06 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox