From: Christoph Hellwig <hch@infradead.org>
To: G SatishKumar <gsatish.ldd@gmail.com>
Cc: linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org,
palmer@sifive.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RISCV:IRQ: Support IRQ_WORK interrupts with self IPI
Date: Tue, 15 Jan 2019 05:41:08 -0800 [thread overview]
Message-ID: <20190115134108.GA13216@infradead.org> (raw)
In-Reply-To: <1546781578-8126-1-git-send-email-gsatish.ldd@gmail.com>
On Sun, Jan 06, 2019 at 07:02:58PM +0530, G SatishKumar wrote:
> This patch adds, IRQ Work interrupts support to RISCV arch.
>
> This patch is based on the arm32 patch ARM 7872/1
> which ports cleanly.
>
> Done set of changes based on RISCV SMP process.
>
> commit bf18525fd793 ("ARM: 7872/1: Support arch_irq_work_raise()
> via self IPIs")
> Author: Stephen Boyd <sboyd at codeaurora.org>
> Date: Tue Oct 29 20:32:56 2013 +0100
>
> By default, IRQ work is run from the tick interrupt (see
> irq_work_run() in update_process_times()). When we're in full
> NOHZ mode, restarting the tick requires the use of IRQ work and
> if the only place we run IRQ work is in the tick interrupt we
> have an unbreakable cycle. Implement arch_irq_work_raise() via
> self IPIs to break this cycle and get the tick started again.
> Note that we implement this via IPIs which are only available on
> SMP builds. This shouldn't be a problem because full NOHZ is only
> supported on SMP builds anyway.
The commit logs here looks oddly indented. Also what workload did you
test this with?
prev parent reply other threads:[~2019-01-15 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-06 13:32 [PATCH] RISCV:IRQ: Support IRQ_WORK interrupts with self IPI G SatishKumar
2019-01-15 13:41 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115134108.GA13216@infradead.org \
--to=hch@infradead.org \
--cc=gsatish.ldd@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox