Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR

Daniel Vetter
2019-01-16T10:25:22Z

On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> It's a debug hack flag useful to work around driver bugs. That's not a
> good idea for a new driver. Especially for a new drm driver.
>
> Aside: the fbdev support should probably be converted over to the new
> generic fbdev support.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> ---
> drivers/staging/vboxvideo/vbox_fb.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c
> index 2181c36c19ab..1da4cb7647b8 100644
> --- a/drivers/staging/vboxvideo/vbox_fb.c
> +++ b/drivers/staging/vboxvideo/vbox_fb.c
> @@ -91,11 +91,6 @@ int vboxfb_create(struct drm_fb_helper *helper,
> fb = &vbox->afb.base;
> helper->fb = fb;
>
> - /*
> - * The last flag forces a mode set on VT switches even if the kernel
> - * does not think it is needed.
> - */
> - info->flags = FBINFO_MISC_ALWAYS_SETPAR;

For the record I screwed up rebasing this one because it was in some patch
that also removed FBINFO_DEFAULT (which is 0, so pointless to set since
the structure is kzalloc'ed). Actually merged patch also removes
FBINFO_DEFAULT :-/ No real harm done though since as explained 0 doesn't
matter here.
-Daniel
> info->fbops = &vboxfb_ops;
>
> /*
> --
> 2.20.1
>

--
Daniel Vetter
Software Engineer, Intel Corporation