From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A9B6C43387 for ; Tue, 15 Jan 2019 15:15:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3EEDC204FD for ; Tue, 15 Jan 2019 15:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547565309; bh=XZuzAqTfW9czMTRIYg514Kc+a2bEVy14Hu3rwwmRLAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mzODemnVGSP+z4QCHGwst1pQFRnZNIJZ5bjuroLJ9ggoToyhsLAsvxVI9p0luLcqD aIF/MovZFlvwdv6etLij7Fn1L4VIJbNdSeswvFdDlyxKIqyzelTH8Z3prYuhpVAs7m nCsLWaVkRLQAJey7IlXfvh5ZPUTPkqD7Nc+53CIk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730694AbfAOPPH (ORCPT ); Tue, 15 Jan 2019 10:15:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:43122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbfAOPPH (ORCPT ); Tue, 15 Jan 2019 10:15:07 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2081B204FD; Tue, 15 Jan 2019 15:15:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547565306; bh=XZuzAqTfW9czMTRIYg514Kc+a2bEVy14Hu3rwwmRLAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pmwjo5Aglx6a5U+vIHXmeZPn9rVsVPdxLG4csslCLirjqMnJBnN67EU8PwZbqi9jd r10OazPdft+fSXQ3/zMeMFrgB2iSI7BHuVq5nZXELUYwk5JGqkgLVTPCeMd4ZZ9pM/ Fhq6AeKTTKvbcGv92wusgHdhTBHnBi7hX/ig9n7M= Date: Tue, 15 Jan 2019 16:15:04 +0100 From: Greg Kroah-Hartman To: Nishad Kamdar Cc: Johan Hovold , devel@driverdev.osuosl.org, Alex Elder , linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org Subject: Re: [PATCH v7 1/3] staging: greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP Message-ID: <20190115151504.GA27454@kroah.com> References: <20190115151317.GA17860@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190115151317.GA17860@kroah.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 15, 2019 at 04:13:17PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 14, 2019 at 08:26:16PM +0530, Nishad Kamdar wrote: > > Convert the GPIO driver to use the GPIO irqchip library > > GPIOLIB_IRQCHIP instead of reimplementing the same. > > > > Reviewed-by: Johan Hovold > > Signed-off-by: Nishad Kamdar > > Did you test build this patch? > > It fails horribly for me: > > drivers/staging/greybus/gpio.c: In function ‘gb_gpio_request_handler’: > drivers/staging/greybus/gpio.c:389:34: error: ‘struct gpio_chip’ has no member named ‘irq’ > irq = irq_find_mapping(ggc->chip.irq.domain, event->which); > ^ > CC [M] drivers/staging/rtl8712/usb_intf.o > drivers/staging/greybus/gpio.c: In function ‘gb_gpio_probe’: > drivers/staging/greybus/gpio.c:577:8: error: implicit declaration of function ‘gpiochip_irqchip_add’; did you mean ‘gpiochip_add’? [-Werror=implicit-function-declaration] > ret = gpiochip_irqchip_add(gpio, irqc, 0, handle_level_irq, > ^~~~~~~~~~~~~~~~~~~~ > gpiochip_add > > > Please be more careful... Hm, this seems to be a problem on my side. You selected the new config symbol, but my quick build system didn't catch that and it didnt regenerate the kernel configuration, which causes this problem. So this is fine, sorry for the noise, my fault. greg k-h