From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECEE1C43387 for ; Tue, 15 Jan 2019 15:32:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B82CE20866 for ; Tue, 15 Jan 2019 15:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547566334; bh=SEa0TraNvTMifLliizmyDEF9OPlEhHSkBlOOkvkK53E=; h=Date:From:To:Subject:References:In-Reply-To:List-ID:From; b=R6pjcokeOre6dkHTmIwRbU8KYuWXt/u7ORx+b+s9Anb7INHhJCd9X7NJYchZMxbKu NQnKwkB4NGNzy9U0mo20eMibeUWM5NQlxJcrvGcyYBVgyXql6mdeygIf7VqS1wbxV7 s52lB3me5Ni30FCZd/thvXn9j/wjN1R2g614p2HQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729514AbfAOPcN (ORCPT ); Tue, 15 Jan 2019 10:32:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:52306 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728679AbfAOPcN (ORCPT ); Tue, 15 Jan 2019 10:32:13 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F24F920675; Tue, 15 Jan 2019 15:32:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547566332; bh=SEa0TraNvTMifLliizmyDEF9OPlEhHSkBlOOkvkK53E=; h=Date:From:To:Subject:References:In-Reply-To:From; b=iCE1MoYR2Y7NotvAuSf8aUOCGRmsMuNIEjLy+CCfP3cwF5zZM4VDxCGQ5b0EOgnLh B8QF2LjXs4k2I1qFPGie0vORSZoAL4MMinPei0jPGem/vkj2wldIQ2vlxjmVAd/4P+ YrKFm+dbn7dt41BW6K4ZEXTsZ7RR1Zvum8XrFYYE= Date: Tue, 15 Jan 2019 16:32:09 +0100 From: Greg Kroah-Hartman To: DRI Development , LKML , Daniel Vetter , Hans de Goede , Bartlomiej Zolnierkiewicz , Alexander Kapshuk Subject: Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR Message-ID: <20190115153209.GA3810@kroah.com> References: <20190115102755.16183-1-daniel.vetter@ffwll.ch> <20190115103829.GC18959@kroah.com> <20190115121228.GO10517@phenom.ffwll.local> <20190115134553.GD30742@kroah.com> <20190115151549.GP10517@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190115151549.GP10517@phenom.ffwll.local> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 15, 2019 at 04:15:49PM +0100, Daniel Vetter wrote: > On Tue, Jan 15, 2019 at 02:45:53PM +0100, Greg Kroah-Hartman wrote: > > On Tue, Jan 15, 2019 at 01:12:28PM +0100, Daniel Vetter wrote: > > > On Tue, Jan 15, 2019 at 11:38:29AM +0100, Greg Kroah-Hartman wrote: > > > > On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote: > > > > > It's a debug hack flag useful to work around driver bugs. That's not a > > > > > good idea for a new driver. Especially for a new drm driver. > > > > > > > > > > Aside: the fbdev support should probably be converted over to the new > > > > > generic fbdev support. > > > > > > > > > > Signed-off-by: Daniel Vetter > > > > > Cc: Greg Kroah-Hartman > > > > > Cc: Hans de Goede > > > > > Cc: Daniel Vetter > > > > > Cc: Bartlomiej Zolnierkiewicz > > > > > Cc: Alexander Kapshuk > > > > > --- > > > > > drivers/staging/vboxvideo/vbox_fb.c | 5 ----- > > > > > 1 file changed, 5 deletions(-) > > > > > > > > > > > > > Reviewed-by: Greg Kroah-Hartman > > > > > > Since Hans wants to destage vboxvideo this cycle probably best I merge > > > this through drm-misc? Just to make sure it's not lost. > > > > Feel free to do so! > > Applied, thanks for your review. > > I think 2/2 is directly staging material for you (somehow > get_maintainers.pl didn't add you to the cc: list, not sure why ...). Can you resend it, I don't see it anywhere...