Re: [PATCH] arch: riscv: support kernel command line forcing when no DTB passed

Andreas Schwab
2019-02-05T17:43:14Z

On Dez 17 2018, Paul Walmsley <paul.walmsley@sifive.com> wrote:

> diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
> index 2c290e6aaa6e..e6b962ff39b1 100644
> --- a/arch/riscv/kernel/setup.c
> +++ b/arch/riscv/kernel/setup.c
> @@ -171,7 +171,14 @@ asmlinkage void __init setup_vm(void)
>
> void __init parse_dtb(unsigned int hartid, void *dtb)
> {
> - early_init_dt_scan(__va(dtb));
> + if (!early_init_dt_scan(__va(dtb)))
> + return;
> +
> + pr_err("No DTB passed to the kernel\n");

Isn't that backwards? early_init_dt_scan returns true if it found a
DTB.

Andreas.

--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."