Re: [PATCH] perf tools: Filter out hidden symbols from labels

Arnaldo Carvalho de Melo
2019-01-29T11:39:56Z

Em Tue, Jan 29, 2019 at 11:25:35AM +0000, Nick Clifton escreveu:
> Hi Arnaldo,
>
> >> there were no objections for rfc, sending patch
> >
> > I don't see a problem, Nick, can you provide an Acked-by, or better yet,
> > a Reviewed-by so that Jiri can collect in this patch and I can push it
> > to perf/urgent?
>
> Sorry - I do not think that I have the authority to do that. I am not a
> perftools maintainer (or a kernel maintainer). For what it is worth the
> patch does look good to me, but I think that a real maintainer needs to
> approve it.

Ok, I was more thinking about this part of
Documentation/process/submittingpatches.txt:

----------------------------
Acked-by: is not as formal as Signed-off-by:. It is a record that the acker
has at least reviewed the patch and has indicated acceptance. Hence patch
mergers will sometimes manually convert an acker's "yep, looks good to me"
into an Acked-by: (but note that it is usually better to ask for an
explicit ack).
----------------------------

But its ok, if you still don't feel this should be added, I'll just
leave a Cc: you, ok?

- Arnaldo