Re: [PATCH] perf tools: Filter out hidden symbols from labels

Arnaldo Carvalho de Melo
2019-02-04T14:45:53Z

Em Mon, Jan 28, 2019 at 02:35:26PM +0100, Jiri Olsa escreveu:
> On Tue, Jan 15, 2019 at 06:38:38PM +0100, Jiri Olsa wrote:
> > On Tue, Jan 15, 2019 at 04:13:16PM +0000, Nick Clifton wrote:
> > > > When perf is built with annobin plugin (RHEL8 build) extra symbols
> > > > are added to its binary:
<SNIP>
> > > > + elf_sym__visibility(sym) != STV_HIDDEN;
> > >
> > > Just to be awkward, if you are going to ignore STV_HIDDEN
> > > symbols then you should probably also ignore STV_INTERNAL ones
> > > as well... Annobin does not generate them, but you never know,
> > > one day some other tool might create some.
> >
> > sounds good, thanks
>
> there were no objections for rfc, sending patch

Thanks, applied to perf/urgent.

- Arnaldo