From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B0B0C43387 for ; Tue, 15 Jan 2019 16:52:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC5D920645 for ; Tue, 15 Jan 2019 16:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730965AbfAOQwt convert rfc822-to-8bit (ORCPT ); Tue, 15 Jan 2019 11:52:49 -0500 Received: from mail.bootlin.com ([62.4.15.54]:59329 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728856AbfAOQwr (ORCPT ); Tue, 15 Jan 2019 11:52:47 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 856E920A9B; Tue, 15 Jan 2019 17:52:45 +0100 (CET) Received: from xps13 (173.203.136.77.rev.sfr.net [77.136.203.173]) by mail.bootlin.com (Postfix) with ESMTPSA id 0F2BA207A3; Tue, 15 Jan 2019 17:52:34 +0100 (CET) Date: Tue, 15 Jan 2019 17:52:32 +0100 From: Miquel Raynal To: Jianxin Pan Cc: Boris Brezillon , , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Carlo Caione , Kevin Hilman , Rob Herring , Liang Yang , Jian Hu , Hanjie Lin , Victor Wan , , , , Subject: Re: [PATCH v9 0/2] mtd: rawnand: meson: add Amlogic NAND driver support Message-ID: <20190115175232.3d82d4a9@xps13> In-Reply-To: <1547566684-57472-1-git-send-email-jianxin.pan@amlogic.com> References: <1547566684-57472-1-git-send-email-jianxin.pan@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jianxin, Jianxin Pan wrote on Tue, 15 Jan 2019 23:38:02 +0800: > These two patches try to add initial NAND driver support for Amlogic Meson > SoCs, current it has been tested on GXL(p212) and AXG(s400) platform. > > Changes since V8 at [9] > - fix build failre at object_is_on_stack > - update Kconfig as Martin's suggested Thanks for this last version, looks good to me. Could you please send a patch to add a MAINTAINERS entry? Also, can we face any deadly failure if someone compiles this driver without the MMC clock driver updated? Thanks, Miquèl